Cleanup doc in TypedPropertyFromCreateMockAssignRector to avoid PHPStan reports

[TomasVotruba]

• add fixture
• Remove var docblock

[samsonasik]

I am thinking if it can use @var MockObject&SomeMockedClass as mock class is mostly intersection typed, or use intersection type if supported (8.1).

/cc @staabm any opinion?

[TomasVotruba]

That would lead to error:

PHPDoc tag @var for property ... with type  ... is incompatible with native type                                                  PHPUnit\Framework\MockObject\MockObject.    

The only solution is to make MockObject generic, probably via phpstan/phpstan-phpunit package, but that would require having package installed.

[TomasVotruba]

Another error in the & case is:

PHPDoc tag @var for property ... contains unresolvable type

Which is understandable, as class type is known and it never implements the MockObject interface

[samsonasik]

what I mean is something like this:

/** @var MockObject&SomeClass */
private MockObject $prop;

intersection should works ok with phpstan subtype, if php 8.1 already, it can be directly typed:

private MockObject&SomeClass $prop;

see PHPUnit doc https://github.com/sebastianbergmann/phpunit/blob/98b9586dbfeed26df628789440cb69eaf5595bdb/src/Framework/TestCase.php#L1338

[samsonasik]

above is what @ruudk questioning on #6177 (review) which valid type as I see

[TomasVotruba]

Could you test it? The first case throws me an error

[samsonasik]

I see, intersection docblock seems somehow can't resolve type when already typed MockObject, but union seems working:

/** @var MockObject|SomeClass */
private MockObject $prop;

[TomasVotruba]

Yet, that's not true. As it's not A or B, but always A.

[staabm]

could someone post a phpstan.org/try snippet with the unexpected error?
(or a small repository with a repro in case phpstan.org/try cannot be used)

I am not sure yet, what the "error" is we are talking about.

I guess we are talking about whats described here:
https://github.com/phpstan/phpstan-phpunit?tab=readme-ov-file#how-to-document-mock-objects-in-phpdocs

[TomasVotruba]

I'll split this into 2 rules, to make both steps separated and let user decide which to use.

[samsonasik]

There is no 11.22.3 version, probably you mean 11.23.5, see https://packagist.org/packages/illuminate/container

[samsonasik]

Suggested change

	"illuminate/container": "11.22.3",
	"illuminate/container": "11.23.5",