Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance] Reduce double traverse on StrictNativeFunctionReturnTypeAnalyzer #6320

Merged
merged 1 commit into from
Sep 21, 2024
Merged

[Performance] Reduce double traverse on StrictNativeFunctionReturnTypeAnalyzer #6320

merged 1 commit into from
Sep 21, 2024

Conversation

samsonasik
Copy link
Member

The findReturnsScoped() already take care of Yield_ and YieldFrom when used on ReturnAnalyzer as passed argument to return false if it exists.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 92f64ff into main Sep 21, 2024
36 checks passed
@samsonasik samsonasik deleted the reduce-double-traverse-strict-native branch September 21, 2024 13:07
@samsonasik samsonasik mentioned this pull request Sep 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsonasik