Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two different yq implementations used among our tooling #953

Open
jstourac opened this issue Sep 26, 2023 · 1 comment
Open

Two different yq implementations used among our tooling #953

jstourac opened this issue Sep 26, 2023 · 1 comment

Comments

@jstourac
Copy link
Member

jstourac commented Sep 26, 2023

As a result of my work on #943 I realized that there are two yq implementations and both are still alive (I was under the impression that the first one is dead since we download the second one in our codebase):

I'm not sure what were reasons to move to the GoLang based one. From the usage in our tests here we use it either to get particular value from yaml file or to update particular variable in the yaml file (using the --inplace flag).

If I don't miss anything, both features are implemented also by the Python based yq implementation which we depend on in our Poetry definition files. See, e.g.:

yq -y --in-place '.BROWSER.NAME="ahoy"' /tmp/test-variables.yml

My proposal is to ditch usage of the GoLang based yq implementation among this project (and also Jenkins docker image) so that we can rely on Poetry definition completely and these two implementations aren't mixed up in our environments.

@bdattoma
Copy link
Contributor

Thanks for the analysis.

IMO we can do a try migrating to python-based lib if this semplify our dependency mgmt.
Something to keep in mind is that the goLang-based one seems more continuously committed. It's probably not a big issue for us, unless there are CVEs which arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants