[Fix] run_robot_test.sh - OC login and return value #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note - regarding the shellcheck, there is also this PR opened #936. |
kornys
previously approved these changes
Sep 21, 2023
Robot Results
|
|
@tarukumar regarding our discussion whether to remove the So, I guess we want to keep it there? Truth is that looking on the code, it won't stop execution even in case of failure. I can update that. |
jstourac
force-pushed
the
runScriptFixes
branch
from
a1c01cd
to
62d7ca2
Compare
|
I added a commit with the check for the |
jstourac
force-pushed
the
runScriptFixes
branch
from
62d7ca2
to
347e339
Compare
|
Note: yesterday I was able to test this on a Mac OS machine - these changes should work just fine. Also note - on Mac OS the original code worked just fine, so probably just Linux users are affected with this. Looks like we have more Mac users than Linux users here (what a shame 😄 ). |
jstourac
force-pushed
the
runScriptFixes
branch
from
347e339
to
61ecc69
Compare
jstourac
added
verified
kornys
approved these changes
Sep 25, 2023
bdattoma
requested changes
Sep 26, 2023
jstourac
force-pushed
the
runScriptFixes
branch
from
61ecc69
to
4c9f8e4
Compare
jstourac
added
needs testing
jstourac
force-pushed
the
runScriptFixes
branch
from
4c9f8e4
to
0386012
Compare
bdattoma
approved these changes
Sep 26, 2023
jstourac
added
verified
jstourac
force-pushed
the
runScriptFixes
branch
from
0386012
to
5ed70ac
Compare
This fixes OC login on my local Fedora 38 machine. Without this change, the strings contain also `"`. Also missing `-` in front of the switch isn't allowed. Tested with Python based `yq` tool: ``` $ yq --version # https://github.com/kislyuk/yq yq 3.2.3 $ yq --help ... -e set the exit status code based on the output; ... -r output raw strings, not JSON texts; ... ``` and also with GoLang based `yq` tool: ``` $ ./yq_linux_amd64 --version # https://github.com/mikefarah/yq yq (https://github.com/mikefarah/yq/) version v4.35.2 $ ./yq_linux_amd64 --help ... -e, --exit-status set exit status if there are no matches or null or false is returned ... -r, --unwrapScalar unwrap scalar, print the value with no quotes, colors or comments. Defaults to true for yaml (default true) ... ```
Return value in case of service account login could be wrong
jstourac
force-pushed
the
runScriptFixes
branch
from
5ed70ac
to
0cd5340
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Rebased. Also created #953. |
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Nov 28, 2023
…vices#943) * [Fix] run_robot_test.sh - OC login This fixes OC login on my local Fedora 38 machine. Without this change, the strings contain also `"`. Also missing `-` in front of the switch isn't allowed. Tested with Python based `yq` tool: ``` $ yq --version # https://github.com/kislyuk/yq yq 3.2.3 $ yq --help ... -e set the exit status code based on the output; ... -r output raw strings, not JSON texts; ... ``` and also with GoLang based `yq` tool: ``` $ ./yq_linux_amd64 --version # https://github.com/mikefarah/yq yq (https://github.com/mikefarah/yq/) version v4.35.2 $ ./yq_linux_amd64 --help ... -e, --exit-status set exit status if there are no matches or null or false is returned ... -r, --unwrapScalar unwrap scalar, print the value with no quotes, colors or comments. Defaults to true for yaml (default true) ... ``` * [Fix] run_robot_test.sh - fix return value Return value in case of service account login could be wrong * [Fix] run_robot_test.sh - let's check return code of yq before oc login
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Jan 2, 2024
…vices#943) * [Fix] run_robot_test.sh - OC login This fixes OC login on my local Fedora 38 machine. Without this change, the strings contain also `"`. Also missing `-` in front of the switch isn't allowed. Tested with Python based `yq` tool: ``` $ yq --version # https://github.com/kislyuk/yq yq 3.2.3 $ yq --help ... -e set the exit status code based on the output; ... -r output raw strings, not JSON texts; ... ``` and also with GoLang based `yq` tool: ``` $ ./yq_linux_amd64 --version # https://github.com/mikefarah/yq yq (https://github.com/mikefarah/yq/) version v4.35.2 $ ./yq_linux_amd64 --help ... -e, --exit-status set exit status if there are no matches or null or false is returned ... -r, --unwrapScalar unwrap scalar, print the value with no quotes, colors or comments. Defaults to true for yaml (default true) ... ``` * [Fix] run_robot_test.sh - fix return value Return value in case of service account login could be wrong * [Fix] run_robot_test.sh - let's check return code of yq before oc login
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes OC login on my local Fedora 38 machine. Without this change,
the strings contain also
".Also missing
-in front of the switch isn't allowed.Tested with Python based
yqtool:and also with GoLang based
yqtool: