ODS-1932 - Verify user can edit a S3 data connection #846
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ... ${DC_SECTION_XP}//tr[td[@data-label="Name"]/*/div[text()="${name}"]]/td[@data-label="Connected workbenches"]/ul/li[text()="${workbench_title}"] | ||
| END | ||
| END | ||
|
|
||
| Data Connection Should Not Be Listed | ||
| [Documentation] Checks a Data Connection is not listed in DS Project details page | ||
| [Arguments] ${name} | ||
| Run keyword And Continue On Failure Wait Until Page Does Not Contain Element | ||
| Run keyword And Continue On Failure Wait Until Page Does Not Contain Element |
Check warning
Code scanning / Robocop
Keyword name '{{ keyword_name }}' does not follow case convention
| @@ -66,25 +56,25 @@ | |||
| Data Connection Should Be Listed | |||
| [Documentation] Checks a Data Connection is listed in DS Project details page | |||
| [Arguments] ${name} ${type} ${connected_workbench} | |||
| Run keyword And Continue On Failure Page Should Contain Element | |||
| Run keyword And Continue On Failure Page Should Contain Element | |||
Check warning
Code scanning / Robocop
Keyword name '{{ keyword_name }}' does not follow case convention
| ... aws_bucket_name=${aws_bucket_name} | ||
| Wait Until Project Is Open project_title=${project_title} | ||
|
|
||
| Edit S3 Data Connection |
Check warning
Code scanning / Robocop
Keyword '{{ keyword_name }}' has too many arguments ({{ arguments_count }}/{{ max_allowed_count }})
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/DataConnections.resource
Fixed
Show fixed
Hide fixed
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/DataConnections.resource
Fixed
Show fixed
Hide fixed
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/DataConnections.resource
Fixed
Show fixed
Hide fixed
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/DataConnections.resource
Fixed
Show fixed
Hide fixed
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/DataConnections.resource
Outdated
Show resolved
Hide resolved
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/DataConnections.resource
Outdated
Show resolved
Hide resolved
...ts/Tests/400__ods_dashboard/430__data_science_pipelines/434__data-science-pipelines-ui.robot
Outdated
Show resolved
Hide resolved
diegolovison
force-pushed
the
edit_data_connection
branch
from
2d17fe8
to
461b25c
Compare
There was a problem hiding this comment.
Robocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
| ... aws_access_key=${DC_S3_AWS_SECRET_ACCESS_KEY} | ||
| ... aws_secret_access=${DC_S3_AWS_SECRET_ACCESS_KEY} | ||
| ... aws_s3_endpoint=${DC_S3_ENDPOINT} aws_region=${DC_S3_REGION} | ||
| Edit S3 Data Connection project_title=${PRJ_TITLE} dc_name=${DC_S3_NAME} |
There was a problem hiding this comment.
can you edit the name too?
bdattoma
added
needs testing
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.