silence output from git-cat-file #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If git cat-file fails, it prints a "fatal:" error message to stderr. We expect this to fail occasionally because we're using it as a test to discover if we need to fetch the PR locally. Add a "log_output" kwarg to git() to allow us to disable the output from the subcommand call, and specifically disable this during the git cat-file operation. A safer fix would be to look for that specific "fatal:" error message string after the git() call and filtering *that* specifically, but that would require another kwarg to git() to optionally disable raising subprocess.CalledProcessError and return the output instead. I'm not sure I want to go there yet.
|
Fixes #16 |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
git cat-filefails, it prints a "fatal:" error message to stderr.We expect this to fail occasionally because we're using it as a test to discover if we need to fetch the PR locally.
Add a "
log_output" kwarg togit()to allow us to disable the output from the subcommand call, and specifically disable this during thegit cat-fileoperation.A safer fix would be to look for that specific "fatal:" error message string after the
git()call and filtering that specifically, but that would require another kwarg togit()to optionally disable raisingsubprocess.CalledProcessErrorand return theoutputinstead. I'm not sure I want to go there yet.