Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy the pre-commit-hook into this repository and convert it to py3 #23

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions downstream_cherry_picker/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import subprocess
import sys
import requests
from shutil import copyfile

__version__ = '1.2.0'

Expand All @@ -21,8 +22,6 @@

PR_URL_REGEX = r'https://github.com/([^/]+)/([^/]+)/pull/(\d+)$'

HOOK_URL = 'https://gist.githubusercontent.com/alfredodeza/252d66dbf4a5c36cfb7b1cb3c0faf445/raw/08cff9560328c0c03b11b9f6ac9db98dbad0a6e4/prepare-commit-msg' # NOQA

logging.basicConfig(format='%(levelname)s: %(message)s', level=logging.INFO)
log = logging.getLogger()

Expand Down Expand Up @@ -125,14 +124,10 @@ def git(*args):

def ensure_hook():
""" Ensure that the .git/hooks/prepare-commit-msg file is ready """
dir = os.path.dirname(os.path.realpath(__file__))
src_hook = f'{dir}/data/prepare-commit-msg'
hook = '.git/hooks/prepare-commit-msg'
# https://gist.github.com/alfredodeza/252d66dbf4a5c36cfb7b1cb3c0faf445
if not os.path.isfile(hook):
log.warn('%s not found, downloading from Gist' % hook)
r = requests.get(HOOK_URL)
fh = open(hook, 'w')
fh.write(r.text)
fh.close()
copyfile(src_hook, hook)
if not os.access(hook, os.X_OK):
st = os.stat(hook)
os.chmod(hook, st.st_mode | stat.S_IXUSR | stat.S_IXGRP | stat.S_IXOTH)
Expand Down
103 changes: 103 additions & 0 deletions downstream_cherry_picker/data/prepare-commit-msg
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
#!/usr/bin/python
"""
This is a prepare-commit-msg hook that fill append commit messages with::

Resolves: {TRACKER}#{TICKET-ID}

For example a RedHat BZ 0001 would look like::

Correct the syntax error

Signed-off-by: Alfredo Deza <[email protected]>

Resolves: rhbz#0001

The requirement is to branch with the right identifier. For the above example
the branch name would need to be: rhbz-0001

This hook will split on `-` and use all lower casing to transform the branch
into the "Resolves" line.

Copy this file to $GITREPOSITORY/.git/hooks/prepare-commit-msg
and mark it executable.
"""
import subprocess
import sys
import os


def which(executable):
locations = (
'/usr/local/bin',
'/bin',
'/usr/bin',
'/usr/local/sbin',
'/usr/sbin',
'/sbin',
)

for location in locations:
executable_path = os.path.join(location, executable)
if os.path.exists(executable_path):
return executable_path

GIT = which('git')
Comment on lines +29 to +44
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shutil.which()?



def branch_name():
try:
name = subprocess.check_output(
[GIT, "symbolic-ref", "HEAD"],
stderr=subprocess.STDOUT).decode()
except Exception as err:
if 'fatal: ref HEAD is not a symbolic ref' in err.output:
# we are in a rebase or detached head state
return ''
# This looks like: refs/heads/12345678/my-cool-feature
# if we ever get a branch that has '/' in it we are going to have
# some issues.
return name.split('/')[-1]
parts = name.split('/')
if len(parts) != 4:
raise ValueError("Branch name has '/' in it which is not allowed")
branch = parts[-1]
return branch


def prepend_commit_msg(branch):
"""Prepend the commit message with `text`"""
msgfile = sys.argv[1]
with open(msgfile) as f:
contents = f.read()

if not branch:
return contents

try:
prefix, ticket_id = branch.split('-')
ticket_id = int(ticket_id)
except ValueError:
# We used to raise here, but if cherry-picking to a different branch
# that doesn't comply it would break preventing the cherry-pick. So we
# print out the warning, but end up returning the contents.
print('skipping commit msg change: Branch name "%s" does not follow required format: {tracker}-{ID}' % branch) # NOQA
return contents

if prefix == 'wip':
# Skip "wip" branches, ie "work in progress"
return contents

resolves_line = "\nResolves: %s#%s" % (prefix.lower(), ticket_id)

with open(msgfile, 'a') as f:
# Don't append if it's already there
if resolves_line not in contents:
f.write(resolves_line)

Comment on lines +67 to +96
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we're invoking the git command, this could be easily done with git interpret-trailers command:

subprocess.run(['git', 'interpret-trailers', f'--trailer Resolves: rhbz#{ticket_id}', '--in-place', sys.argv[1]], shell=True, check=True)

That said, a pre-commit hook is not needed for this, and IMHO it should rather be done with interepreter trailers:

-    git('-c', 'core.editor=/bin/true', 'cherry-pick', '-x', '%s~..%s' % (first, last))
+    git('-c', 'core.editor=/bin/true', 'cherry-pick', '-x', '--no-commit', '%s~..%s' % (first, last))
+    git('commit', '--trailer "Resolves: rhbz#{$bz}"', '--no-edit')
    # Merge this rhbz branch back into our starting branch.
    git('checkout', starting_branch)
    git('merge', '--ff-only', 'rhbz-' + bz)
    git('branch', '-d', 'rhbz-' + bz)


def main():
branch = branch_name().strip().strip('\n')
prepend_commit_msg(branch)

if __name__ == '__main__':
main()
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,4 +137,5 @@ def run_tests(self):
'pytest-flake8',
],
cmdclass={'test': PyTest, 'bump': BumpCommand, 'release': ReleaseCommand},
package_data={'downstream_cherry_picker': ['data/prepare-commit-msg']}
)