Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2309195: fix pvc reclaimspace & keyrotation annotation filter #191

Merged

Conversation

iPraveenParihar
Copy link
Member

This commit adds a check in StorageClass event handler to filter out PVC not needed for Reconcile.

  • If SC has ReclaimSpace annotation, PVCs without ReclaimSpace annotation will be enqueued.
  • If SC has KeyRotation annotation, PVCs without KeyRotation annotation will be enqueued.

Signed-off-by: Praveen M [email protected]
(cherry picked from commit 0cc07e7)

This commit adds a check in StorageClass event handler
to filter out PVC not needed for Reconcile.

- If SC has ReclaimSpace annotation, PVCs without ReclaimSpace
  annotation will be enqueued.
- If SC has KeyRotation annotation, PVCs without KeyRotation
  annotation will be enqueued.

Signed-off-by: Praveen M <[email protected]>
(cherry picked from commit 0cc07e7)
@iPraveenParihar iPraveenParihar self-assigned this Sep 2, 2024
Copy link

openshift-ci bot commented Sep 2, 2024

@iPraveenParihar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

fix pvc reclaimspace & keyrotation annotation filter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the approved label Sep 2, 2024
@iPraveenParihar iPraveenParihar changed the title fix pvc reclaimspace & keyrotation annotation filter BUG 2309195: fix pvc reclaimspace & keyrotation annotation filter Sep 2, 2024
Copy link

openshift-ci bot commented Sep 2, 2024

@iPraveenParihar: This pull request references Bugzilla bug 2309195, which is invalid:

  • expected the bug to target the "ODF 4.17.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 2309195: fix pvc reclaimspace & keyrotation annotation filter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iPraveenParihar
Copy link
Member Author

/bugzilla refresh

Copy link

openshift-ci bot commented Sep 2, 2024

@iPraveenParihar: This pull request references Bugzilla bug 2309195, which is invalid:

  • expected the bug to target the "ODF 4.17.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Madhu-1
Copy link
Member

Madhu-1 commented Sep 3, 2024

@iPraveenParihar this need to be rebased on top of another PR from @Rakshith-R or vice-versa, the CI is failing here as well, please pick the commit fixed this ci problem

@Madhu-1
Copy link
Member

Madhu-1 commented Sep 3, 2024

/bugzilla refresh

Copy link

openshift-ci bot commented Sep 3, 2024

@Madhu-1: This pull request references Bugzilla bug 2309195, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.17.0) matches configured target release for branch (ODF 4.17.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Sep 3, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@Madhu-1: This pull request references Bugzilla bug 2309195, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.17.0) matches configured target release for branch (ODF 4.17.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Praveen M <[email protected]>
(cherry picked from commit 56ff3c1)
@Madhu-1
Copy link
Member

Madhu-1 commented Sep 3, 2024

/lgtm
/approve

Copy link

openshift-ci bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iPraveenParihar, Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Madhu-1,iPraveenParihar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ebcdf4e into red-hat-storage:release-4.17 Sep 3, 2024
12 checks passed
Copy link

openshift-ci bot commented Sep 3, 2024

@iPraveenParihar: All pull requests linked via external trackers have merged:

Bugzilla bug 2309195 has been moved to the MODIFIED state.

In response to this:

BUG 2309195: fix pvc reclaimspace & keyrotation annotation filter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants