-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG 2309195: fix pvc reclaimspace & keyrotation annotation filter #191
BUG 2309195: fix pvc reclaimspace & keyrotation annotation filter #191
Conversation
This commit adds a check in StorageClass event handler to filter out PVC not needed for Reconcile. - If SC has ReclaimSpace annotation, PVCs without ReclaimSpace annotation will be enqueued. - If SC has KeyRotation annotation, PVCs without KeyRotation annotation will be enqueued. Signed-off-by: Praveen M <[email protected]> (cherry picked from commit 0cc07e7)
@iPraveenParihar: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@iPraveenParihar: This pull request references Bugzilla bug 2309195, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/bugzilla refresh |
@iPraveenParihar: This pull request references Bugzilla bug 2309195, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@iPraveenParihar this need to be rebased on top of another PR from @Rakshith-R or vice-versa, the CI is failing here as well, please pick the commit fixed this ci problem |
/bugzilla refresh |
@Madhu-1: This pull request references Bugzilla bug 2309195, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Praveen M <[email protected]> (cherry picked from commit 56ff3c1)
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iPraveenParihar, Madhu-1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ebcdf4e
into
red-hat-storage:release-4.17
@iPraveenParihar: All pull requests linked via external trackers have merged: Bugzilla bug 2309195 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This commit adds a check in StorageClass event handler to filter out PVC not needed for Reconcile.
Signed-off-by: Praveen M [email protected]
(cherry picked from commit 0cc07e7)