Skip to content

Commit

Permalink
Add --acm-version CLI option
Browse files Browse the repository at this point in the history
Signed-off-by: Shylesh Kumar Mohan <[email protected]>
  • Loading branch information
shylesh committed Jul 22, 2024
1 parent 3177bf6 commit 07296eb
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
1 change: 1 addition & 0 deletions conf/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ higher priority).
* `skip_ocp_deployment` - Skip the OCP deployment step or not (Default: false)
* `skip_ocs_deployment` - Skip the OCS deployment step or not (Default: false)
* `ocs_version` - Version of OCS that is being deployed
* `acm_version` - Version of acm to be used for this run (applicable mostly to DR scenarios)
* `vm_template` - VMWare template to use for RHCOS images
* `fio_storageutilization_min_mbps` - Minimal write speed of FIO used in workload_fio_storageutilization
* `TF_LOG_LEVEL` - Terraform log level
Expand Down
8 changes: 8 additions & 0 deletions ocs_ci/framework/pytest_customization/ocscilib.py
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,11 @@ def pytest_addoption(parser):
"(e.g. quay.io/rhceph-dev/ocs-olm-operator:latest-4.3)"
),
)
parser.addoption(
"--acm-version",
dest="acm_version",
help="acm version(e.g. 2.8) to be used for the current run",
)
parser.addoption(
"--upgrade-acm-version",
dest="upgrade_acm_version",
Expand Down Expand Up @@ -665,6 +670,9 @@ def process_cluster_cli_params(config):
if custom_kubeconfig_location:
os.environ["KUBECONFIG"] = custom_kubeconfig_location
ocsci_config.RUN["kubeconfig"] = custom_kubeconfig_location
acm_version = get_cli_param(config, "--acm-version")
if acm_version:
ocsci_config.ENV_DATA["acm_version"] = acm_version
upgrade_acm_version = get_cli_param(config, "--upgrade-acm-version")
if upgrade_acm_version:
ocsci_config.UPGRADE["upgrade_acm_version"] = upgrade_acm_version
Expand Down
2 changes: 1 addition & 1 deletion ocs_ci/utility/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -5041,7 +5041,7 @@ def sum_of_two_storage_sizes(storage_size1, storage_size2, convert_size=1024):
size = size1 + size2
new_storage_size = f"{size}{unit}"
return new_storage_size


def is_z_stream_upgrade():
"""
Expand Down

0 comments on commit 07296eb

Please sign in to comment.