Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change pdb max unavailable to 2 if we have at least 5 mons in a cluster #10071

Merged
merged 2 commits into from
Jul 19, 2024
Merged

change pdb max unavailable to 2 if we have at least 5 mons in a cluster #10071

merged 2 commits into from
Jul 19, 2024

Conversation

vavuthu
Copy link
Contributor

@vavuthu vavuthu commented Jul 10, 2024

@vavuthu vavuthu requested review from a team as code owners July 10, 2024 13:52
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Jul 10, 2024
@vavuthu vavuthu added the team/ecosystem Ecosystem team related issues/PRs label Jul 10, 2024
@vavuthu vavuthu force-pushed the fix_mon_count_testcases_arbiter branch from 6a5cdc8 to cb1d807 Compare July 11, 2024 07:32
ocs-ci
ocs-ci reviewed Jul 11, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: j-043vu2clva36-a
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_lso_vmdk_3m_6w_arbiter.yaml
PR Test Suite: pre_upgrade or pre_ocs_upgrade or ocs_upgrade or post_ocs_upgrade or post_upgrade
PR Test Path: tests/functional/z_cluster/upgrade/test_check_pdb_post_upgrade.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@vavuthu vavuthu added the Verified Mark when PR was verified and log provided label Jul 11, 2024
@openshift-ci openshift-ci bot added the lgtm label Jul 11, 2024
Shrivaibavi
Shrivaibavi approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@Shrivaibavi Shrivaibavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shylesh
shylesh approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@shylesh shylesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mashetty330, Shrivaibavi, shylesh, vavuthu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vavuthu vavuthu merged commit ed75f13 into red-hat-storage:master Jul 19, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@mashetty330 mashetty330 mashetty330 approved these changes

@Shrivaibavi Shrivaibavi Shrivaibavi approved these changes

@shylesh shylesh shylesh approved these changes

Assignees

@shylesh shylesh

@Shrivaibavi Shrivaibavi

@mashetty330 mashetty330

Labels
lgtm size/S PR that changes 10-29 lines team/ecosystem Ecosystem team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vavuthu @shylesh @Shrivaibavi @ocs-ci @mashetty330