Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stretch cluster + CNV automation #10077

Merged
merged 12 commits into from
Sep 6, 2024

Conversation

mashetty330
Copy link
Contributor

No description provided.

@mashetty330 mashetty330 added the team/e2e E2E team related issues/PRs label Jul 11, 2024
@mashetty330 mashetty330 self-assigned this Jul 11, 2024
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines size/L PR that changes 100-499 lines and removed size/M PR that changes 30-99 lines labels Jul 11, 2024
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-stj29
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_netsplit.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-stj29
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_netsplit.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-stj30
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_netsplit.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-stj30
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_netsplit.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-stj30
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_netsplit.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-stj30
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_netsplit.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

cnv_namespace.delete(resource_name=constants.CNV_NAMESPACE)
logger.info(f"Deleted the namespace {constants.CNV_NAMESPACE}")

def cleanup_cnv(self, check_cnv_installed=False):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename it to uninstall_cnv

ocs_ci/deployment/cnv.py Show resolved Hide resolved
ocs_ci/deployment/cnv.py Show resolved Hide resolved
volumeimportsource_obj = get_volumeimportsource(pvc_obj=pvc_obj)
vm_obj.delete()
log.info(f"Successfully deleted VM {vm_obj.name}")
pvc_obj.delete()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not need to wait for the resource to delete?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default wait=True, so delete itself makes sure the resource is deleted. correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the wait here is for the delete command to complete. It will not wait for the resource to delete.
Please check https://github.com/mashetty330/ocs-ci/blob/cdc6601c397f41b37d0c2522de0a94035a2a8ae4/ocs_ci/ocs/ocp.py#L434

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    def delete(self):
        """
        Delete the VirtualMachine
        """
        self.vm_ocp_obj.delete(resource_name=self._vm_name)
        self.vm_ocp_obj.wait_for_delete(resource_name=self._vm_name, timeout=180)



@pytest.fixture()
def setup_vms_standalone_pvc(request, project_factory, setup_cnv):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the need to pass the setup_cnv here?

vm_obj = None

def factory():
nonlocal vm_obj
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc string missing

@mashetty330 mashetty330 force-pushed the sc_cnv branch 2 times, most recently from cdc6601 to 6b1a390 Compare August 12, 2024 06:34
@pull-request-size pull-request-size bot added size/XL and removed size/L PR that changes 100-499 lines labels Aug 12, 2024
@openshift-ci openshift-ci bot added the lgtm label Sep 2, 2024
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-sts2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_zone_shutdown_and_crash.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-sts2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_zone_shutdown_and_crash.py:: TestZoneShutdownsAndCrashes::test_zone_crashes
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-sts2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_zone_shutdown_and_crash.py:: TestZoneShutdownsAndCrashes::test_zone_crashes
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-sts2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_zone_shutdown_and_crash.py:: TestZoneShutdownsAndCrashes::test_zone_crashes
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-sts2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_zone_shutdown_and_crash.py::TestZoneShutdownsAndCrashes::test_zone_crashes
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-sts2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_zone_shutdown_and_crash.py::TestZoneShutdownsAndCrashes::test_zone_crashes
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-sts2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_zone_shutdown_and_crash.py::TestZoneShutdownsAndCrashes::test_zone_shutdowns
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

@openshift-ci openshift-ci bot added the lgtm label Sep 5, 2024
Copy link

openshift-ci bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Akarsha-rai, mashetty330, PrasadDesala

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PrasadDesala PrasadDesala merged commit 16b6700 into red-hat-storage:master Sep 6, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/XL team/e2e E2E team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants