Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing test_performance_profile_validation #10085

Merged
merged 24 commits into from
Oct 21, 2024
Merged

Fixing test_performance_profile_validation #10085

merged 24 commits into from
Oct 21, 2024

Conversation

pintojoy
Copy link
Contributor

This fixes #10053

@pintojoy pintojoy self-assigned this Jul 12, 2024
@pintojoy pintojoy requested review from a team as code owners July 12, 2024 11:02
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Jul 12, 2024
ocs-ci
ocs-ci reviewed Jul 12, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name: jopinto-pprofile
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/z_cluster/test_performance_profile_validation.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci
ocs-ci reviewed Jul 12, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name: jopinto-pprofile
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/z_cluster/test_performance_profile_validation.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci
ocs-ci reviewed Jul 15, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name: jopinto-pprofile
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/z_cluster/test_performance_profile_validation.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

@pintojoy
Copy link
Contributor Author

Test is passed here https://url.corp.redhat.com/484396d

tests/functional/z_cluster/test_performance_profile_validation.py::TestProfileDefaultValuesCheck::test_validate_cluster_resource_profile[lean] immediately after test execution: 604.59
2024-07-18 00:03:03 PASSED
2024-07-18 00:03:03 ------------------------------ live log teardown -------------------------------

tests/functional/z_cluster/test_performance_profile_validation.py::TestProfileDefaultValuesCheck::test_validate_cluster_resource_profile[performance] immediately after test execution: 3.93
2024-07-17 23:52:48 PASSED
2024-07-17 23:52:48 ------------------------------ live log teardown -------------------------------

tests/functional/z_cluster/test_performance_profile_validation.py::TestProfileDefaultValuesCheck::test_validate_cluster_resource_profile[balanced] immediately after test execution: 604.51
2024-07-18 00:13:16 PASSED
2024-07-18 00:13:16 ------------------------------ live log teardown -------------------------------

@pintojoy pintojoy added the Verified Mark when PR was verified and log provided label Jul 17, 2024
@pintojoy pintojoy removed the Verified Mark when PR was verified and log provided label Aug 7, 2024
@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines and removed size/M PR that changes 30-99 lines labels Aug 13, 2024
ocs-ci
ocs-ci reviewed Aug 14, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name: jopinto-pprofile
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/z_cluster/test_performance_profile_validation.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci
ocs-ci reviewed Aug 19, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name: jopinto-pprofile
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/z_cluster/test_performance_profile_validation.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

@pintojoy pintojoy added Verified Mark when PR was verified and log provided Squad/Brown labels Aug 28, 2024
@pintojoy
Copy link
Contributor Author

pintojoy commented Sep 4, 2024

Verification logs: https://url.corp.redhat.com/5d35f24

pintojoy and others added 14 commits October 10, 2024 11:36
@pintojoy
Analyzing the failure
9ec6dbb 
Signed-off-by: pintojoy <[email protected]>
@pintojoy
Fixing mon values from constants.py
22e390f 
Signed-off-by: pintojoy <[email protected]>
@pintojoy
Fixing mon values from constants.py
29c0716 
Signed-off-by: pintojoy <[email protected]>
@pintojoy
Resolving merge conflicts
51b2bef 
Signed-off-by: Joy John Pinto <[email protected]>
@pintojoy
Fixing script issues
bb81b66 
Signed-off-by: Joy John Pinto <[email protected]>
@pintojoy
Test for failures
bf5fd9c 
Signed-off-by: Joy John Pinto <[email protected]>
@pintojoy
Fixing script issues
3db7082 
Signed-off-by: Joy John Pinto <[email protected]>
@pintojoy
Fixing script issues
92e51ff 
Signed-off-by: Joy John Pinto <[email protected]>
@pintojoy
Fixing script issues
e1aacba 
Signed-off-by: Joy John Pinto <[email protected]>
@pintojoy
Fixing script issues
5eadd23 
Signed-off-by: Joy John Pinto <[email protected]>
@pintojoy
Fixing script issues
3d5f0cb 
Signed-off-by: Joy John Pinto <[email protected]>
@pintojoy
Fixing script issues
f6fd94d 
Signed-off-by: Joy John Pinto <[email protected]>
@pintojoy
Fixing script issues
6354d63 
Signed-off-by: Joy John Pinto <[email protected]>
@pintojoy
Increasing timeout
64ec736 
Signed-off-by: Joy John Pinto <[email protected]>
am-agrawa
am-agrawa reviewed Oct 10, 2024
View reviewed changes
tests/functional/z_cluster/test_performance_profile_validation.py Outdated
try:
exist_performance_profile = storage_cluster.data["spec"]["resourceProfile"]
curr_prof = storage_cluster.data["spec"]["resourceProfile"]
log.info(f"Current performance prfile is {curr_prof}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log.info(f"Current performance prfile is {curr_prof}")
log.info(f"Current performance profile is {curr_prof}")

tests/functional/z_cluster/test_performance_profile_validation.py Show resolved Hide resolved
tests/functional/z_cluster/test_performance_profile_validation.py Outdated Show resolved Hide resolved
tests/functional/z_cluster/test_performance_profile_validation.py Show resolved Hide resolved
ocs_ci/helpers/helpers.py Outdated Show resolved Hide resolved
@am-agrawa am-agrawa closed this Oct 10, 2024
@am-agrawa am-agrawa reopened this Oct 10, 2024
@pintojoy
Addressing review comments
cd27619 
Signed-off-by: Joy John Pinto <[email protected]>
@openshift-ci openshift-ci bot added the lgtm label Oct 10, 2024
amr1ta
amr1ta approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@amr1ta amr1ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: am-agrawa, amr1ta, pintojoy, ramkiperiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ramkiperiy ramkiperiy merged commit 735f850 into red-hat-storage:master Oct 21, 2024
6 of 7 checks passed
@am-agrawa
Copy link
Contributor

@pintojoy Can we please backport the fix to all relevant versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@yitzhak12 yitzhak12 yitzhak12 left review comments

@am-agrawa am-agrawa am-agrawa approved these changes

@amr1ta amr1ta amr1ta approved these changes

@ramkiperiy ramkiperiy ramkiperiy approved these changes

Assignees

@ramkiperiy ramkiperiy

@amr1ta amr1ta

@am-agrawa am-agrawa

@pintojoy pintojoy

Labels
lgtm size/L PR that changes 100-499 lines Squad/Brown Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_change_cluster_resource_profile test failing with KeyError: 'resourceProfile'
7 participants
@pintojoy @am-agrawa @yitzhak12 @ramkiperiy @amr1ta @ocs-ci @openshift-merge-robot