Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a new test for rwo to rwop migration #10087

Merged
merged 3 commits into from
Jul 14, 2024
Merged

Adding a new test for rwo to rwop migration #10087

merged 3 commits into from
Jul 14, 2024

Conversation

ypersky1980
Copy link
Contributor

This test implements the following flow:

  1. Creating a RWO PVC for RWD/CephFS pvcs
  2. Implementing migration prodecure ( https://kubernetes.io/docs/tasks/administer-cluster/change-pv-access-mode-readwriteoncepod/#migrating-existing-persistentvolumes )
  3. After PVC mode is changed from RWO to RWOP - verifying that after the first pod is attached , the second pod with the same priority is not attached to the PVC and is in status Pending.
  4. A change in helpers.py to create a PVC on a specific PV.

@ypersky1980 ypersky1980 requested review from a team as code owners July 12, 2024 20:23
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Jul 12, 2024
ocs-ci
ocs-ci reviewed Jul 12, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/pv/pv_services/test_pvc_migrate_rwo_to_rwop.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@ypersky1980 ypersky1980 added the Verified Mark when PR was verified and log provided label Jul 12, 2024
ebenahar
ebenahar reviewed Jul 14, 2024
View reviewed changes
tests/functional/pv/pv_services/test_pvc_migrate_rwo_to_rwop.py
log = logging.getLogger(__name__)


@pytest.mark.parametrize(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

polarion IDs are missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10090 - create a Github issue for this , once the test is created in Polarion - will add the ID to the code.

@openshift-ci openshift-ci bot added the lgtm label Jul 14, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DanielOsypenko, ebenahar, ypersky1980

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebenahar ebenahar merged commit a2c0c5d into master Jul 14, 2024
6 of 7 checks passed
@ypersky1980 ypersky1980 deleted the ypersky_migration_rwo_to_rwop branch July 14, 2024 10:52
amr1ta pushed a commit to amr1ta/ocs-ci that referenced this pull request Jul 25, 2024
@ypersky1980
Adding a new test for rwo to rwop migration (red-hat-storage#10087)
85d52d8 
Signed-off-by: Yulia Persky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@DanielOsypenko DanielOsypenko DanielOsypenko approved these changes

@ebenahar ebenahar ebenahar approved these changes

Assignees

@ebenahar ebenahar

@DanielOsypenko DanielOsypenko

Labels
lgtm size/L PR that changes 100-499 lines Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ypersky1980 @ebenahar @ocs-ci @DanielOsypenko