Deploy ODF4.17 via UI #10095
Merged
Deploy ODF4.17 via UI #10095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: oviner <[email protected]>
ocs-ci
reviewed
Jul 14, 2024
ebondare
approved these changes
Jul 15, 2024
DanielOsypenko
approved these changes
Jul 15, 2024
petr-balogh
reviewed
Jul 15, 2024
Comment on lines
+1868
to
+1871
| **deployment_4_7, | ||
| **deployment_4_9, | ||
| **deployment_4_10, | ||
| **deployment_4_11, |
There was a problem hiding this comment.
Can we think of some other solution to avoid using such old versions in our code base?
Not needed for this PR but I think we should change the logic here of locators, to be able to merge some of previous and just do copy whole 4.17 from 4.16 and just update some specific values for 4.17 which are required.
petr-balogh
approved these changes
Jul 15, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DanielOsypenko, ebondare, OdedViner, petr-balogh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
amr1ta
pushed a commit
to amr1ta/ocs-ci
that referenced
this pull request
Jul 25, 2024
Signed-off-by: oviner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.