Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsphere ipi deployment - not all nodes created #10116

Merged
merged 1 commit into from
Jul 17, 2024
Merged

vsphere ipi deployment - not all nodes created #10116

merged 1 commit into from
Jul 17, 2024

Conversation

vavuthu
Copy link
Contributor

@vavuthu vavuthu commented Jul 16, 2024

Signed-off-by: vavuthu [email protected]

@vavuthu vavuthu requested a review from a team as a code owner July 16, 2024 06:12
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Jul 16, 2024
@vavuthu vavuthu added the team/ecosystem Ecosystem team related issues/PRs label Jul 16, 2024
ocs-ci
ocs-ci reviewed Jul 16, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: deployment
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job FAILED (installation failed, tests not executed).

ocs-ci
ocs-ci reviewed Jul 16, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: deployment
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@vavuthu
Copy link
Contributor Author

vavuthu commented Jul 16, 2024

Verified

2024-07-16 20:01:34  10:31:34 - MainThread - ocs_ci.utility.utils - INFO  - Executing command: oc --kubeconfig /home/jenkins/current-cluster-dir/openshift-cluster-dir/auth/kubeconfig get Node  -o yaml
2024-07-16 20:05:10  10:35:01 - MainThread - ocs_ci.utility.vsphere - INFO  - Powering on VMs: ['jnk-pr10116b7191-2hknt-worker-0-sbq5b']
2024-07-16 20:05:10  10:35:10 - MainThread - ocs_ci.utility.vsphere - INFO  - Waiting for VMs ['jnk-pr10116b7191-2hknt-worker-0-sbq5b'] to power on based on network connectivity. Current VMs IPs: [None]
.
.
.
2024-07-16 20:09:13  10:39:02 - MainThread - ocs_ci.ocs.node - WARNING  - waiting for 6 nodes to create but found 5 nodes
2024-07-16 20:09:13  10:39:02 - MainThread - ocs_ci.utility.utils - INFO  - Going to sleep for 60 seconds before next iteration
2024-07-16 20:10:09  10:40:02 - MainThread - ocs_ci.utility.utils - INFO  - Executing command: oc --kubeconfig /home/jenkins/current-cluster-dir/openshift-cluster-dir/auth/kubeconfig get Node  -o yaml
2024-07-16 20:10:09  10:40:02 - MainThread - ocs_ci.ocs.node - INFO  - All 6 nodes are created successfully.

@vavuthu vavuthu added the Verified Mark when PR was verified and log provided label Jul 16, 2024
petr-balogh
petr-balogh reviewed Jul 17, 2024
View reviewed changes
ocs_ci/ocs/node.py Outdated
@@ -1754,6 +1761,29 @@ def verify_all_nodes_created():
)


def power_on_vms():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about rename to something like power_on_ocp_node_vms()

And mention to docstring that it makes sure all cluster node VMs are powered on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@vavuthu vavuthu force-pushed the vsphere_ipi_deployment_issue_not_all_nodes_created branch from 049e18c to 221d07b Compare July 17, 2024 08:37
@openshift-ci openshift-ci bot added the lgtm label Jul 17, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dahorak, petr-balogh, vavuthu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-balogh petr-balogh merged commit 13d7f45 into red-hat-storage:master Jul 17, 2024
5 of 6 checks passed
@vavuthu
Copy link
Contributor Author

vavuthu commented Aug 17, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link
Collaborator

@vavuthu: new pull request created: #10314

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 17, 2024
Merged
@vavuthu
Copy link
Contributor Author

vavuthu commented Aug 17, 2024

/cherry-pick release-4.14

@vavuthu
Copy link
Contributor Author

vavuthu commented Aug 17, 2024

/cherry-pick release-4.13

@vavuthu
Copy link
Contributor Author

vavuthu commented Aug 17, 2024

/cherry-pick release-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 17, 2024
Merged
@openshift-cherrypick-robot
Copy link
Collaborator

@vavuthu: new pull request created: #10315

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Collaborator

@vavuthu: new pull request created: #10316

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 17, 2024
Merged
@openshift-cherrypick-robot
Copy link
Collaborator

@vavuthu: new pull request created: #10317

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@petr-balogh petr-balogh petr-balogh approved these changes

@dahorak dahorak dahorak approved these changes

Assignees

@dahorak dahorak

@petr-balogh petr-balogh

Labels
lgtm size/M PR that changes 30-99 lines team/ecosystem Ecosystem team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vavuthu @openshift-cherrypick-robot @dahorak @petr-balogh @ocs-ci