Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix s3_list_objects_v2 function keyword args default value #10137

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

mashetty330
Copy link
Contributor

Fixes #10127

Signed-off-by: Mahesh Shetty <[email protected]>
@mashetty330 mashetty330 added team/e2e E2E team related issues/PRs MCG Multi Cloud Gateway / NooBaa related issues labels Jul 18, 2024
@mashetty330 mashetty330 self-assigned this Jul 18, 2024
@mashetty330 mashetty330 requested a review from a team as a code owner July 18, 2024 05:53
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-stj16
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/object/mcg/lifecycle/test_mcg_namespace_s3_ops_rpc.py::TestMcgNamespaceS3OperationsRpc::test_mcg_namespace_basic_s3_ops_rpc
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-stj16
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/object/mcg/lifecycle/test_mcg_namespace_s3_ops_crd.py::TestMcgNamespaceS3OperationsCrd::test_mcg_namespace_basic_s3_ops_crd
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

avd-sagare
avd-sagare previously approved these changes Jul 18, 2024
parikshithb
parikshithb previously approved these changes Jul 18, 2024
@mashetty330 mashetty330 dismissed stale reviews from parikshithb and avd-sagare via ac79d3d July 18, 2024 07:33
@openshift-ci openshift-ci bot removed the lgtm label Jul 18, 2024
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Jul 18, 2024
@pull-request-size pull-request-size bot added size/XS and removed size/L PR that changes 100-499 lines labels Jul 18, 2024
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-stj16
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/object/mcg/lifecycle/test_mcg_namespace_s3_ops_crd.py::TestMcgNamespaceS3OperationsCrd::test_mcg_namespace_basic_s3_ops_crd
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

@openshift-ci openshift-ci bot added the lgtm label Jul 18, 2024
Copy link

openshift-ci bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: avd-sagare, mashetty330, parikshithb, PrasadDesala

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PrasadDesala PrasadDesala merged commit ca793ba into red-hat-storage:master Jul 18, 2024
8 of 9 checks passed
amr1ta pushed a commit to amr1ta/ocs-ci that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm MCG Multi Cloud Gateway / NooBaa related issues size/XS team/e2e E2E team related issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid type for parameter error in setup_mcg_bg_features()
5 participants