Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add carriage_return to const file #10163

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

AviadP
Copy link
Contributor

@AviadP AviadP commented Jul 23, 2024

added ENTER_KEY, needed for odf cli testing

@AviadP AviadP requested a review from a team as a code owner July 23, 2024 13:59
Copy link
Contributor

@shylesh shylesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AviadP, OdedViner, shylesh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shylesh
Copy link
Contributor

shylesh commented Jul 23, 2024

Currently, no test is exercising this path. However, Aviad will soon have some scenarios which need this code.Hence merging this PR.

@shylesh shylesh merged commit fea0b39 into red-hat-storage:master Jul 23, 2024
5 of 7 checks passed
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: acceptance
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.16-ga
OCS VERSION: 4.16
tested against branch: master

Job FAILED (installation failed, tests not executed).

amr1ta pushed a commit to amr1ta/ocs-ci that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants