adding --config-file param functionality to deployment #10724

shivamdurgbuns · 2024-10-24T05:23:52Z

This is to enable feature https://issues.redhat.com/browse/OCSQE-2249

openshift-ci · 2024-10-24T05:23:58Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shivamdurgbuns

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

shivamdurgbuns · 2024-10-24T10:30:04Z

Verification job: https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/43488/console

ocs_ci/utility/utils.py

vavuthu · 2024-11-06T06:37:33Z

ocs_ci/deployment/helpers/external_cluster_helpers.py

+            params (str): Parameter to pass to exporter script
+
+        Returns:
+            str: absolute path to config.ini gile


Suggested change

str: absolute path to config.ini gile

str: absolute path to config.ini file

vavuthu · 2024-11-06T06:39:51Z

ocs_ci/deployment/helpers/external_cluster_helpers.py

-        cmd = f"{python_version} {script_path} {params}"
+        ocs_version = version.get_semantic_ocs_version_from_config()
+        # if condition is for the new feature introduced in
+        # 4.17 in OCSQE-2249 where the this covers the test case


Suggested change

# 4.17 in OCSQE-2249 where the this covers the test case

# 4.17 in OCSQE-2249 where this covers the test case

vavuthu · 2024-11-06T06:41:34Z

ocs_ci/utility/utils.py

+        params (str): Parameter to pass to be converted into config.ini file.
+
+    Returns:
+        config_ini_file.name (str): Path to the config.ini file.


leave blank line after this

vavuthu · 2024-11-06T06:43:19Z

ocs_ci/utility/utils.py

+        config_ini_file.name (str): Path to the config.ini file.
+    """
+    data = "[Configurations]\n"
+    import re


move to import section at the beginning of file

vavuthu · 2024-11-06T06:43:54Z

ocs_ci/utility/utils.py

+    )
+    with open(config_ini_file.name, "w") as fd:
+        fd.write(data)
+    log.info(f"config.ini fike for cluster is located at {config_ini_file.name}")


Suggested change

log.info(f"config.ini fike for cluster is located at {config_ini_file.name}")

log.info(f"config.ini file for cluster is located at {config_ini_file.name}")

vavuthu · 2024-11-06T06:44:24Z

ocs_ci/utility/utils.py

+        params (str): Parameter to pass to be converted into config.ini file.
+
+    Returns:
+        config_ini_file.name (str): Path to the config.ini file.


Suggested change

config_ini_file.name (str): Path to the config.ini file.

str: Path to the config.ini file.

vavuthu · 2024-11-06T06:46:42Z

ocs_ci/utility/utils.py

@@ -5198,3 +5199,38 @@ def extract_image_urls(string_data):
    # Find all URLs that start with 'registry.redhat.io'
    image_urls = re.findall(r'registry\.redhat\.io[^\s"]+', string_data)
    return image_urls
+
+
+def params_to_configini_file(params):


rename the function which resembles the work of function. In this case it creates config ini file. ( e.g: create_config_ini_file()

Signed-off-by: Shivam Durgbuns <[email protected]>

ocs-ci

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.16-ga
OCS VERSION: 4.16
tested against branch: master

Job FAILED (installation failed, tests not executed).

petr-balogh · 2025-01-16T22:14:12Z

conf/ocsci/external_cluster_with_config_file.yaml

@@ -0,0 +1,3 @@
+---
+ENV_DATA:
+  use_config_file: true


The name here is too generic doesn't tell anything about this use_confi_file.

As it's config file for exporter script to external RHCS cluster, more reasonable sounds something like:
rhcs_external_use_config_file

Also, please document this value in:
https://github.com/red-hat-storage/ocs-ci/blob/master/conf/README.md

ocs-ci

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.16-ga
OCS VERSION: 4.16
tested against branch: master

Job FAILED (installation failed, tests not executed).

shivamdurgbuns · 2025-01-17T14:23:43Z

Reopening this PR here #11160

shivamdurgbuns requested a review from a team as a code owner October 24, 2024 05:23

pull-request-size bot added the size/M PR that changes 30-99 lines label Oct 24, 2024

shivamdurgbuns force-pushed the test/RHSTOR-5260 branch from 84d29b8 to fea5ff5 Compare October 24, 2024 07:32

shivamdurgbuns added the Verified Mark when PR was verified and log provided label Oct 24, 2024

paraggit reviewed Oct 28, 2024

View reviewed changes

ocs_ci/utility/utils.py Show resolved Hide resolved

shivamdurgbuns mentioned this pull request Oct 28, 2024

Fixing issue by adding range of +-1.0 numbers to avoid the errors #10764

Closed

shivamdurgbuns force-pushed the test/RHSTOR-5260 branch from 1d3b77f to 7a41e2d Compare November 4, 2024 08:36

vavuthu reviewed Nov 6, 2024

View reviewed changes

shivamdurgbuns force-pushed the test/RHSTOR-5260 branch from 7a41e2d to 6e8fa66 Compare November 20, 2024 09:48

PrasadDesala added the Customer defects Defects automated aspart of GSS closed loop label Nov 28, 2024

openshift-merge-robot added the needs-rebase label Jan 8, 2025

shivamdurgbuns added 4 commits January 9, 2025 12:59

adding --config-file param functionality to deployment

575cb42

Signed-off-by: Shivam Durgbuns <[email protected]>

Adding missing arguments for the function upload_config_ini_file

43a9133

Signed-off-by: Shivam Durgbuns <[email protected]>

Adding the comments with feature ID and polarian ID

14cbad8

Signed-off-by: Shivam Durgbuns <[email protected]>

typo fixes

5cb4c1d

Signed-off-by: Shivam Durgbuns <[email protected]>

shivamdurgbuns force-pushed the test/RHSTOR-5260 branch from 6e8fa66 to a1a9ec7 Compare January 9, 2025 07:30

openshift-merge-robot removed the needs-rebase label Jan 9, 2025

shivamdurgbuns force-pushed the test/RHSTOR-5260 branch from a1a9ec7 to f3498b2 Compare January 9, 2025 08:23

Changing function name to create_config_ini_file

38f8965

Signed-off-by: Shivam Durgbuns <[email protected]>

shivamdurgbuns force-pushed the test/RHSTOR-5260 branch from f3498b2 to 38f8965 Compare January 9, 2025 08:25

ocs-ci reviewed Jan 16, 2025

View reviewed changes

petr-balogh reviewed Jan 16, 2025

View reviewed changes

ocs-ci reviewed Jan 17, 2025

View reviewed changes

shivamdurgbuns closed this Jan 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding --config-file param functionality to deployment #10724

adding --config-file param functionality to deployment #10724

shivamdurgbuns commented Oct 24, 2024

openshift-ci bot commented Oct 24, 2024

shivamdurgbuns commented Oct 24, 2024

vavuthu Nov 6, 2024

vavuthu Nov 6, 2024

vavuthu Nov 6, 2024

vavuthu Nov 6, 2024

vavuthu Nov 6, 2024

vavuthu Nov 6, 2024

vavuthu Nov 6, 2024

ocs-ci left a comment

petr-balogh Jan 16, 2025

ocs-ci left a comment

shivamdurgbuns commented Jan 17, 2025

	str: absolute path to config.ini gile
	str: absolute path to config.ini file

	# 4.17 in OCSQE-2249 where the this covers the test case
	# 4.17 in OCSQE-2249 where this covers the test case

	log.info(f"config.ini fike for cluster is located at {config_ini_file.name}")
	log.info(f"config.ini file for cluster is located at {config_ini_file.name}")

	config_ini_file.name (str): Path to the config.ini file.
	str: Path to the config.ini file.

adding --config-file param functionality to deployment #10724

adding --config-file param functionality to deployment #10724

Conversation

shivamdurgbuns commented Oct 24, 2024

openshift-ci bot commented Oct 24, 2024

shivamdurgbuns commented Oct 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

shivamdurgbuns commented Jan 17, 2025