Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Azure STS deployment support #10869

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP: Azure STS deployment support #10869

wants to merge 3 commits into from

Conversation

clacroix12
Copy link
Contributor

@clacroix12 clacroix12 added Needs Deployment Testing Needs Deployment and Some Tier1 Testing team/ecosystem Ecosystem team related issues/PRs labels Nov 15, 2024
@clacroix12 clacroix12 requested review from Neon-White and a team November 15, 2024 23:33
@clacroix12 clacroix12 requested a review from a team as a code owner November 15, 2024 23:33
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Nov 15, 2024
petr-balogh
petr-balogh previously approved these changes Nov 18, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Nov 18, 2024
vavuthu
vavuthu previously approved these changes Nov 22, 2024
View reviewed changes
@clacroix12
Azure STS deployment support
847df86 
Signed-off-by: Coady LaCroix <[email protected]>
@clacroix12
Azure STS teardown steps
1f072e0 
Signed-off-by: Coady LaCroix <[email protected]>
@clacroix12 clacroix12 dismissed stale reviews from vavuthu and petr-balogh via 1f072e0 November 26, 2024 23:47
@openshift-ci openshift-ci bot removed the lgtm label Nov 26, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 26, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clacroix12

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

2 similar comments
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clacroix12

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clacroix12

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vavuthu vavuthu vavuthu left review comments

@petr-balogh petr-balogh petr-balogh left review comments

@Neon-White Neon-White Awaiting requested review from Neon-White

At least 2 approving reviews are required to merge this pull request.

Assignees

@petr-balogh petr-balogh

@vavuthu vavuthu

Labels
do-not-merge/work-in-progress Needs Deployment Testing Needs Deployment and Some Tier1 Testing size/L PR that changes 100-499 lines team/ecosystem Ecosystem team related issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clacroix12 @petr-balogh @vavuthu