Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes bucket policy NotAction issue #10938

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Fixes bucket policy NotAction issue #10938

merged 1 commit into from
Jan 3, 2025

Conversation

udaysk23
Copy link
Contributor

Fixes #9968

@udaysk23 udaysk23 added TestCase failing MCG Multi Cloud Gateway / NooBaa related issues Squad/Red backport-required Mark for PRs that need to be backported to older release branches labels Nov 27, 2024
@udaysk23 udaysk23 requested a review from a team as a code owner November 27, 2024 10:20
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Nov 27, 2024
ocs-ci
ocs-ci reviewed Nov 27, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ukurundw-60
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/object/mcg/test_bucket_policy.py::TestS3BucketPolicy::test_bucket_policy_elements_NotAction
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

@udaysk23 udaysk23 added the Verified Mark when PR was verified and log provided label Nov 27, 2024
@udaysk23 udaysk23 force-pushed the bucket_policy_issue branch from 404abf6 to d84e3f1 Compare November 28, 2024 05:45
sagihirshfeld
sagihirshfeld approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@sagihirshfeld sagihirshfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Dec 30, 2024
ypersky1980
ypersky1980 approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@ypersky1980 ypersky1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mashetty330, sagihirshfeld, udaysk23, ypersky1980

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@keesturam keesturam merged commit c1bf88c into red-hat-storage:master Jan 3, 2025
6 of 7 checks passed
paraggit pushed a commit to paraggit/ocs-ci that referenced this pull request Jan 6, 2025
@udaysk23 @paraggit
Fixes bucket policy NotAction issue (red-hat-storage#10938)
755dde3 
Signed-off-by: Uday Kurundwade <[email protected]>
@udaysk23
Copy link
Contributor Author

udaysk23 commented Jan 8, 2025

/cherrypick release-4.17

@udaysk23
Copy link
Contributor Author

udaysk23 commented Jan 8, 2025

/cherrypick release-4.16

@openshift-cherrypick-robot
Copy link
Collaborator

@udaysk23: new pull request created: #11123

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 8, 2025
Open
@openshift-cherrypick-robot
Copy link
Collaborator

@udaysk23: new pull request created: #11124

In response to this:

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@mashetty330 mashetty330 mashetty330 approved these changes

@ypersky1980 ypersky1980 ypersky1980 approved these changes

@sagihirshfeld sagihirshfeld sagihirshfeld approved these changes

@keesturam keesturam Awaiting requested review from keesturam

Assignees

@sagihirshfeld sagihirshfeld

@ypersky1980 ypersky1980

@mashetty330 mashetty330

Labels
backport-required Mark for PRs that need to be backported to older release branches lgtm MCG Multi Cloud Gateway / NooBaa related issues size/S PR that changes 10-29 lines Squad/Red TestCase failing Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_bucket_policy_elements_NotAction fails because correct expectations are not kept for effect=Allow
7 participants
@udaysk23 @openshift-cherrypick-robot @sagihirshfeld @ocs-ci @ypersky1980 @mashetty330 @keesturam