Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

must gather minimal crds test case #10972

Merged
merged 16 commits into from
Jan 14, 2025
Merged

must gather minimal crds test case #10972

merged 16 commits into from
Jan 14, 2025

Conversation

fbalak
Copy link
Contributor

@fbalak fbalak commented Dec 3, 2024

No description provided.

@fbalak fbalak self-assigned this Dec 3, 2024
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Dec 3, 2024
@fbalak fbalak marked this pull request as ready for review December 20, 2024 13:59
@fbalak fbalak requested a review from a team as a code owner December 20, 2024 13:59
@fbalak fbalak requested a review from a team as a code owner January 6, 2025 13:20
fbalak added 9 commits January 6, 2025 15:37
@fbalak
updata path logic
43155ac 
Signed-off-by: fbalak <[email protected]>
@fbalak
updata markers
ebf16c7 
Signed-off-by: fbalak <[email protected]>
@fbalak
updata markers
90c39ce 
Signed-off-by: fbalak <[email protected]>
@fbalak
updata markers
6bf4df1 
Signed-off-by: fbalak <[email protected]>
@fbalak
updata markers
9a1d43d 
Signed-off-by: fbalak <[email protected]>
@fbalak
updata markers
f5adb96 
Signed-off-by: fbalak <[email protected]>
@fbalak
updata import
b427326 
Signed-off-by: fbalak <[email protected]>
@fbalak
updata markers
e64f89b 
Signed-off-by: fbalak <[email protected]>
@fbalak
updata markers
d3b195a 
Signed-off-by: fbalak <[email protected]>
@fbalak
Copy link
Contributor Author

fbalak commented Jan 7, 2025

Verified: https://jenkins-csb-odf-qe-ocs4.dno.corp.redhat.com/job/qe-deploy-ocs-cluster/45393/

@fbalak fbalak added the Verified Mark when PR was verified and log provided label Jan 7, 2025
suchita-g
suchita-g previously approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@suchita-g suchita-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 13, 2025
petr-balogh
petr-balogh reviewed Jan 13, 2025
View reviewed changes
tests/functional/z_cluster/test_must_gather_minimal_crds.py Outdated Show resolved Hide resolved
tests/functional/z_cluster/test_must_gather_minimal_crds.py Outdated
Comment on lines 137 to 138
for path in paths:
paths_exist.append(path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same here?

@openshift-ci openshift-ci bot removed the lgtm label Jan 13, 2025
@openshift-ci openshift-ci bot added the lgtm label Jan 13, 2025
@fbalak
Copy link
Contributor Author

fbalak commented Jan 14, 2025

Verified: https://jenkins-csb-odf-qe-ocs4.dno.corp.redhat.com/job/qe-deploy-ocs-cluster/45627

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fbalak, petr-balogh, suchita-g

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fbalak fbalak merged commit 9108c04 into red-hat-storage:master Jan 14, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suchita-g suchita-g suchita-g approved these changes

@petr-balogh petr-balogh petr-balogh approved these changes

@dahorak dahorak Awaiting requested review from dahorak

Assignees

@petr-balogh petr-balogh

@fbalak fbalak

@suchita-g suchita-g

Labels
lgtm size/L PR that changes 100-499 lines Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbalak @petr-balogh @suchita-g