[Stretch cluster] Support zone unaware apps for zone shutdown tests #11000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mashetty330 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mashetty330
added
team/e2e
added 3 commits
January 3, 2025 18:10
Signed-off-by: Mahesh Shetty <[email protected]>
Signed-off-by: Mahesh Shetty <[email protected]>
Signed-off-by: Mahesh Shetty <[email protected]>
mashetty330
force-pushed
the
stretch-zone-unaware
branch
from
a7e0dc9 to
325a89a
Compare
pull-request-size
bot
added
size/XL
and removed
size/L
avd-sagare
reviewed
Jan 3, 2025
| nodes_not_ready.extend( | ||
| [node for node in worker_nodes if node.status() != "Ready"] | ||
| ) | ||
| nodes_not_ready.extend( |
There was a problem hiding this comment.
combine these two list comprehensions into one ?
avd-sagare
reviewed
Jan 3, 2025
| nodes, | ||
| fencing, | ||
| ): | ||
|
|
There was a problem hiding this comment.
can you please add test steps here? It will be easy to check what this test does.
Signed-off-by: Mahesh Shetty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.