wrap s3 benchmark-tool - ns in hostname fixed #11104
Conversation
Signed-off-by: Daniel Osypenko <[email protected]>
ocs_ci/ocs/warp.py
Outdated
| # avoid failing DNS server to resolve hostname, when running on cluster with custom storage namespace | ||
| if config.ENV_DATA["cluster_namespace"] not in self.host: | ||
| self.host = f"s3.{config.ENV_DATA['cluster_namespace']}.svc" |
There was a problem hiding this comment.
Please remove the condition and change line 39 to self.host = f"s3.{config.ENV_DATA['cluster_namespace']}.svc"
Signed-off-by: Daniel Osypenko <[email protected]>
|
/cherry-pick release-4.17 |
|
@DanielOsypenko: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.16 |
|
@DanielOsypenko: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.15 |
|
@DanielOsypenko: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DanielOsypenko, sagihirshfeld, udaysk23 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
DanielOsypenko
changed the title
The hostname for wrap s3 benchmark-tool is now dynamic, tuned to a storage namespace.
test run Pass: https://url.corp.redhat.com/218b7dc