Adding support in creation of bucket class with mcg cli and a new test case for creation of rgw namespacestore using mcg-cli #11119
Conversation
…t case for creation of rgw namespace using mcg-cli Signed-off-by: Yulia Persky <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ypersky1980 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Yulia Persky <[email protected]>
Signed-off-by: Yulia Persky <[email protected]>
Signed-off-by: Yulia Persky <[email protected]>
ocs_ci/ocs/resources/mcg.py
Outdated
| f"bucketclass create {placement_type}{name}{backingstores}{placement_policy}{replication_policy}" | ||
| ) | ||
| elif namespacestores: # bucket class is over namespacestores | ||
| namestores_name_list = [ |
There was a problem hiding this comment.
We could hijack the existing logic for backingstores if we replace "backingstores" with "stores", and check if we're here for namespaces based on whether namespace_policy is not None.
There was a problem hiding this comment.
@sagihirshfeld Following our conversation, I'm going to resolve this comment by separating cli_create_bucketclass method to two methods:
cli_create_bucketclass_over_backingspacestores and cli_create_bucketclass_over_namespacestores .
ocs_ci/ocs/resources/bucketclass.py
Outdated
| @@ -209,10 +209,12 @@ def _create_bucket_class(bucket_class_dict): | |||
| interfaces[interface.lower()]( | |||
| name=bucket_class_name, | |||
| backingstores=backingstores, | |||
| namespacestores=namespacestores, | |||
There was a problem hiding this comment.
This will cause an error when interface.lower == 'oc' because mcg.py::MCG::oc_create_bucketclass doesn't have this argument.
There was a problem hiding this comment.
@sagihirshfeld Thank you for pointing this out. The method mcg.py::MCG::oc_create_bucketclass will be called now ( after the last commit) with the correct arguments.
…ucketclass_over_backingspacestores and cli_create_bucketclass_over_namespacestores Signed-off-by: Yulia Persky <[email protected]>
ocs_ci/ocs/resources/mcg.py
Outdated
| replication_policy=None, | ||
| ): | ||
| """ | ||
| Creates a new NooBaa bucket class using the noobaa cli | ||
| Creates a new NooBaa bucket class using the noobaa cli over either backingstores |
There was a problem hiding this comment.
| Creates a new NooBaa bucket class using the noobaa cli over either backingstores | |
| Creates a new NooBaa bucket class using the noobaa cli over backingstores |
| self.exec_mcg_cmd( | ||
| f"bucketclass create namespace-bucketclass {namespace_policy_type} " | ||
| f"--resource={namestores_name_str} {name}" | ||
| ) |
There was a problem hiding this comment.
This is correct for the single NSS type, but please also address the multi and cache options.
For the scope of this PR, just raise a NotImplementedError for the other two types. We'll implement those in follow-up PRs.
There was a problem hiding this comment.
@sagihirshfeld Done.
Signed-off-by: Yulia Persky <[email protected]>
This PR implements the following enhancement to cli_create_bucketclass method : in the past it was creating only backingstore with mcg-cli and from now on it will be able to create a bucketclass with mcg-cli command also for namespacestore.
Following this enhancement it was possible to add a new test case which implements creation of namespacestore and bucketclass for rgw using mcg-cli commands.
In the next PR I will implement automation of https://issues.redhat.com/browse/DFBUGS-1035 ( creating namespacestore and bucketclass on rgw bucket and writing IO to this bucket).