Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dr_helpers and dr_workload to support VRG preservation in ODF 4.18 and AppSet workload health check #11141

Merged

Conversation

sidhant-agrawal
Copy link
Contributor

This PR includes updates to two files:

  • dr_helpers.py: Skips waiting for VRG deletion starting from ODF 4.18, while retaining the wait behavior for ODF 4.17 and below.
  • dr_workload.py: Update AppSet workload deployment verification to use the health status instead of phase

@sidhant-agrawal sidhant-agrawal added DR Metro and Regional DR related PRs Squad/Turquoise labels Jan 13, 2025
@sidhant-agrawal sidhant-agrawal requested a review from a team as a code owner January 13, 2025 05:52
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Jan 13, 2025
…onward.

Enhance VRG checks for discovered applications.

Signed-off-by: Sidhant Agrawal <[email protected]>
@sidhant-agrawal
Copy link
Contributor Author

Verified using ODF 4.18.0-100: https://url.corp.redhat.com/326e572

@sidhant-agrawal sidhant-agrawal requested a review from a team January 15, 2025 10:44
@sidhant-agrawal sidhant-agrawal added the Verified Mark when PR was verified and log provided label Jan 15, 2025
Copy link
Contributor

@shylesh shylesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: keemano, shylesh, sidhant-agrawal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sidhant-agrawal sidhant-agrawal merged commit 59bcd00 into red-hat-storage:master Jan 17, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DR Metro and Regional DR related PRs lgtm size/M PR that changes 30-99 lines Squad/Turquoise Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants