Happy path test case for selinux relabeling in rwop #9572
Conversation
Signed-off-by: Vishakha Kathole <[email protected]>
vkathole
added
Needs Testing
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vkathole The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| Steps: | ||
| 1. Create cephfs pvcs and attach pod with more than 100K files across multiple nested directories | ||
| 2. Take md5sum for them some random files and get pod restart time | ||
| 3. Apply the fix for SeLinux-relabeling |
There was a problem hiding this comment.
is the step 3 applicable to this test?
Signed-off-by: Vishakha Kathole <[email protected]>
Signed-off-by: Vishakha Kathole <[email protected]>
| @magenta_squad | ||
| @tier1 | ||
| class TestSelinuxrelabel(E2ETest): | ||
| def create_deploymentconfig_pod(self, pvc_name=None, **kwargs): |
There was a problem hiding this comment.
can we use create_dc_pods from https://github.com/red-hat-storage/ocs-ci/ests/fixtures.py?
| ) | ||
|
|
||
| log = logging.getLogger(__name__) | ||
|
|
| time.sleep(waiting_time) | ||
| log.info(f"Backup PV {pod_obj} created") | ||
|
|
||
| @pytest.mark.parametrize("copies", [5]) |
There was a problem hiding this comment.
Do you have one test case? If yes, why do you use parameterize?
| log.info( | ||
| f"Sleep 120 seconds so the logs in {self.pod_obj.name} will be updated" | ||
| ) | ||
| time.sleep(120) |
There was a problem hiding this comment.
Do you wait for a specific log? if yes, you can use the generator TimeoutSampler
| @magenta_squad | ||
| @tier1 | ||
| class TestSelinuxrelabel(E2ETest): | ||
| def create_deploymentconfig_pod(self, pvc_name=None, **kwargs): |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. |
|
This pull request has been automatically closed due to inactivity. Please re-open if these changes are still required. |
|
This pull request has been automatically closed due to inactivity. Please re-open if these changes are still required. |
No description provided.