Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tests to automate change of recovery profiles as part of RHSTOR-5149 #9642

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Adding tests to automate change of recovery profiles as part of RHSTOR-5149 #9642

wants to merge 16 commits into from

Conversation

pintojoy
Copy link
Contributor

@pintojoy pintojoy commented Apr 5, 2024 •
edited
Loading

This test intends to automate change of recovery profile through odfcli tool.

@pintojoy pintojoy self-assigned this Apr 5, 2024
@pintojoy pintojoy requested a review from a team as a code owner April 5, 2024 12:00
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Apr 5, 2024
@pintojoy pintojoy requested review from keesturam and ramkiperiy April 5, 2024 12:00
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pintojoy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ramkiperiy
ramkiperiy reviewed Apr 23, 2024
View reviewed changes
tests/functional/odf-cli/test_set_recovery_profile_to_favour_new_io.py Outdated


@brown_squad
@tier1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we setting this default and that why its part of tier1? because in cases where we need recovery IO to be faster good to set it based on that so good to add this part of tier4 or recovery scenario like node, osd failure tests.

ramkiperiy
ramkiperiy reviewed Apr 23, 2024
View reviewed changes
tests/functional/odf-cli/test_set_recovery_profile_to_favour_new_io.py Outdated
pytest.param("high_recovery_ops"),
],
)
def test_set_recovery_profile_odfcli(self, recovery_profile):
Copy link
Contributor

@ramkiperiy ramkiperiy Apr 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have options to reset the recovery profile?

@pintojoy pintojoy requested a review from a team as a code owner May 21, 2024 13:23
@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines and removed size/M PR that changes 30-99 lines labels May 21, 2024
@pintojoy pintojoy changed the title Adding tests to automate change of recovery profiles as part of RHSTOR-5149 [WIP] Adding tests to automate change of recovery profiles as part of RHSTOR-5149 May 21, 2024
@pintojoy pintojoy added the DO NOT MERGE Do not merge this change!! label May 21, 2024
ocs-ci
ocs-ci reviewed Jun 4, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: jopinto-nodes
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/z_cluster/cluster_expansion/test_add_capacity.py::TestAddCapacityRecoveryProfile::test_add_capacity_recovery_profile_cli
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job FAILED (installation failed, tests not executed).

@pintojoy pintojoy changed the title [WIP] Adding tests to automate change of recovery profiles as part of RHSTOR-5149 Adding tests to automate change of recovery profiles as part of RHSTOR-5149 Jun 4, 2024
ocs-ci
ocs-ci reviewed Jun 4, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: jopinto-nodes
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/z_cluster/cluster_expansion/test_add_capacity.py::TestAddCapacityRecoveryProfile::test_add_capacity_recovery_profile_cli
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job FAILED (installation failed, tests not executed).

pintojoy added 2 commits June 10, 2024 18:37
@pintojoy
Fixing merge conflict
57185a2 
Signed-off-by: pintojoy <[email protected]>
@pintojoy
Fixing merge conflict
b8f5340 
Signed-off-by: pintojoy <[email protected]>
pintojoy added 3 commits June 10, 2024 18:42
@pintojoy
Deleting irrelevent tests
6edf174 
Signed-off-by: pintojoy <[email protected]>
@pintojoy
Redrafting the test
d498ea3 
Signed-off-by: pintojoy <[email protected]>
@pintojoy
Fixing tox issues
d4c5f40 
Signed-off-by: pintojoy <[email protected]>
ocs-ci
ocs-ci reviewed Jun 26, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name: jopinto-prval
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/z_cluster/cluster_expansion/test_add_capacity.py::TestAddCapacityRecoveryProfile::test_add_capacity_recovery_profile_cli
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci
ocs-ci reviewed Jul 2, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: jopinto-nodes1
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/z_cluster/cluster_expansion/test_add_capacity.py::TestAddCapacityRecoveryProfile::test_add_capacity_recovery_profile_cli
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job FAILED (installation failed, tests not executed).

ocs-ci
ocs-ci reviewed Jul 2, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name: jopinto-prval
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/z_cluster/cluster_expansion/test_add_capacity.py::TestAddCapacityRecoveryProfile::test_add_capacity_recovery_profile_cli
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci
ocs-ci reviewed Jul 10, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name: jopinto-prv
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/z_cluster/cluster_expansion/test_add_capacity.py::TestAddCapacityRecoveryProfile::test_add_capacity_recovery_profile_cli
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

@pintojoy
Copy link
Contributor Author

Test logs for test_add_capacity_recovery_profile_cli[high_client_ops] and test_add_capacity_recovery_profile_cli[balanced] can be found at https://url.corp.redhat.com/d670ce6

2024-07-11 14:02:03 04:32:03 - MainThread - ocs_ci.framework.pytest_customization.reports - INFO - duration reported by tests/functional/z_cluster/cluster_expansion/test_add_capacity.py::TestAddCapacityRecoveryProfile::test_add_capacity_recovery_profile_cli[balanced] immediately after test execution: 404.41
2024-07-11 14:02:03 PASSED

2024-07-11 15:27:47 05:57:47 - MainThread - ocs_ci.framework.pytest_customization.reports - INFO - duration reported by tests/functional/z_cluster/cluster_expansion/test_add_capacity.py::TestAddCapacityRecoveryProfile::test_add_capacity_recovery_profile_cli[high_client_ops] immediately after test execution: 4491.15
2024-07-11 15:27:47 PASSED

pintojoy added 2 commits July 11, 2024 16:30
@pintojoy
Fixing script issue
0bcf61f 
Signed-off-by: pintojoy <[email protected]>
@pintojoy
Fixing script issue
e7b6503 
Signed-off-by: pintojoy <[email protected]>
@pintojoy
Copy link
Contributor Author

Test logs for test_add_capacity_recovery_profile_cli[high_recovery_ops]: https://url.corp.redhat.com/0c9a5af

2024-07-11 20:05:20 10:35:19 - MainThread - ocs_ci.utility.utils - INFO - Executing command: oc -n openshift-storage rsh rook-ceph-tools-75f778d7b4-f9kbr ceph status --format json-pretty
2024-07-11 20:05:20 10:35:20 - MainThread - ocs_ci.utility.utils - INFO - Executing command: oc -n openshift-storage rsh rook-ceph-tools-75f778d7b4-f9kbr ceph health --format json-pretty
2024-07-11 20:05:21 10:35:21 - MainThread - ocs_ci.ocs.cluster - INFO - {'status': 'HEALTH_OK', 'checks': {}, 'mutes': []}
2024-07-11 20:05:21 10:35:21 - MainThread - ocs_ci.ocs.cluster - INFO - [{'state_name': 'active+clean', 'count': 4}]
2024-07-11 20:05:21 10:35:21 - MainThread - ocs_ci.ocs.cluster - INFO - Re-balance completed! This is attempt 3 out of 3 repeats. This rebalance check needs to prove it 3 times in row.
2024-07-11 20:05:21 10:35:21 - MainThread - ocs_ci.framework.pytest_customization.reports - INFO - duration reported by tests/functional/z_cluster/cluster_expansion/test_add_capacity.py::TestAddCapacityRecoveryProfile::test_add_capacity_recovery_profile_cli[high_recovery_ops] immediately after test execution: 527.62
2024-07-11 20:05:21 PASSED

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the lifecycle/stale No recent activity label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@ramkiperiy ramkiperiy ramkiperiy left review comments

@keesturam keesturam Awaiting requested review from keesturam

At least 2 approving reviews are required to merge this pull request.

Assignees

@pintojoy pintojoy

Labels
lifecycle/stale No recent activity needs-rebase size/L PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pintojoy @openshift-merge-robot @ramkiperiy @ocs-ci