Update dr_workload fixture and test_failover_and_relocate.py #9859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am-agrawa
approved these changes
May 28, 2024
|
Verified on ODF 4.16.0-108 |
- Use pull model by default for ODF 4.16+ - Remove redundant tests for pull model Signed-off-by: Sidhant Agrawal <[email protected]>
sidhant-agrawal
force-pushed
the
push_to_pull_model
branch
from
cc516a5 to
d575232
Compare
parikshithb
approved these changes
Jul 19, 2024
prsurve
approved these changes
Jul 19, 2024
keesturam
approved these changes
Jul 24, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: am-agrawa, keesturam, parikshithb, prsurve, sidhant-agrawal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
amr1ta
pushed a commit
to amr1ta/ocs-ci
that referenced
this pull request
Jul 25, 2024
…-storage#9859) - Use pull model by default for ODF 4.16+ - Remove redundant tests for pull model Signed-off-by: Sidhant Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the dr_workload fixture to prioritize user-defined appset_model value. If model value is not specified, the default behavior now uses "pull" model for ODF versions 4.16 and above.
Removes redundant "pull" model tests from
test_failover_and_relocate.pyas they are now covered by the default behavior for ODF 4.16 and above.