Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for allow successful data re-balance on VSphere/Azure platforms #9994

Merged
merged 2 commits into from
Jul 10, 2024
+2 −2
Merged

Increase timeout for allow successful data re-balance on VSphere/Azure platforms #9994

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
526439c
increase timeout for data re-balance on vsphere ipi
am-agrawa Jun 27, 2024
13a1b2e
rebase
am-agrawa Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/functional/z_cluster/cluster_expansion/test_add_capacity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def add_capacity_test(ui_flag=False):
osd_pod_names_post_expansion = [pod.name for pod in osd_pods_post_expansion]
restarted_osds = list()
logger.info(
"Checking if existing OSD pods were restarted (deleted) post add capacity (bug 1931601)"
"Checking if existing OSD pods were restarted (deleted) post adding capacity (bug 1931601)"
)

for pod in existing_osd_pod_names:
Expand Down Expand Up @@ -112,7 +112,7 @@ def add_capacity_test(ui_flag=False):
verify_storage_device_class(device_class)
verify_device_class_in_osd_tree(ct_pod, device_class)

check_ceph_health_after_add_capacity(ceph_rebalance_timeout=3600)
check_ceph_health_after_add_capacity(ceph_rebalance_timeout=5400)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not mandatory, but if the issue is only with vSphere IPI, maybe we can do something like this:

timeout = 3600 if is_vsphere_ipi_cluster() else 5400
check_ceph_health_after_add_capacity(ceph_rebalance_timeout=timeout)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, data re-balance issue is also seen with VSphere UPI and Azure IPI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay



@brown_squad
Expand Down
Loading