Provider Mode: Object Dashboard: fix RGW performance card #1489
Conversation
alfonsomthd
force-pushed
the
fix-rgw-perf-card
branch
from
d2dcfdf
to
422bab6
Compare
Signed-off-by: Alfonso Martínez <[email protected]>
alfonsomthd
force-pushed
the
fix-rgw-perf-card
branch
from
422bab6
to
c14452b
Compare
| @@ -219,7 +219,7 @@ const ServiceTypeRGW: React.FC<ServiceTypeProps> = ({ queries, metric }) => { | |||
| const loading = getLoading || putLoading; | |||
| const error = !!getError || !!putError; | |||
| const data = !!get && !!put; | |||
| const response: Response = React.useMemo(() => { | |||
| const response: DataPoint<Date>[][] = React.useMemo(() => { | |||
There was a problem hiding this comment.
We need to test this with multiple versions before backporting for now this is working but the reason this chart is failing is because the data structure suddenly changed in the metrics.
There was a problem hiding this comment.
@bipuladh This has been tested with a 4.16 BM cluster (the same version as in the reported issue) so we're safe backporting to 4.16.
Do we need to backport this to 4.15?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alfonsomthd, bipuladh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit b0ce957
into
red-hat-storage:master
|
/cherry-pick release-4.16 |
|
@alfonsomthd: new pull request created: #1503 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.16-compatibility |
|
@alfonsomthd: new pull request created: #1504 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2276393
BEFORE: page crash when selecting
Object Gateway (RGW)on Performance Card (Object Dashboard)AFTER: