Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(sending messages) fix routes files in the app.py #157

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

SaarCohen93
Copy link
Contributor

so after refactoring we need to add the changes to the home.html.
in addition I fixed the read me problem from the last PR.
Mor ask me to add back the layout.html

lmilbaum
lmilbaum previously approved these changes Jan 16, 2020
Copy link
Contributor

@lmilbaum lmilbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SaarCohen93
Copy link
Contributor Author

@lioramilbaum
resolved conflicts from GitHun gui, hope thats ok

Copy link
Contributor

@lmilbaum lmilbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing 'fix...' comment and there are still conflicts to resolve

@SaarCohen93
Copy link
Contributor Author

I fixed all the conflicts, seems now everything is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants