Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get the app going #176

Merged
merged 3 commits into from
Jan 27, 2020
Merged

Get the app going #176

merged 3 commits into from
Jan 27, 2020

Conversation

BarakMerdler
Copy link
Contributor

@BarakMerdler BarakMerdler commented Jan 24, 2020 •
edited by lmilbaum
Loading

fix #162 #155 #146 #130 #103 #99 #98 #85 #83 #80 #78 #68 #
@lioramilbaum
get the app going

@lmilbaum lmilbaum self-requested a review January 24, 2020 18:13
@lmilbaum
Copy link
Contributor

Add a fix comment

@lmilbaum
Copy link
Contributor

There is a similar code in #175

@BarakMerdler
Copy link
Contributor Author

Add a fix comment

Didn't get it, what needs to be fixed? what comment?

There is a similar code in #175

Yes, I used the parts that @morbitton wrote

@BarakMerdler
Copy link
Contributor Author

fix #162 #155 #146 #130 #103 #99 #98 #85 #83 #80 #78 #68 #

lmilbaum
lmilbaum approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@lmilbaum lmilbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmilbaum lmilbaum merged commit c5a6f4d into redhat-beyond:master Jan 27, 2020
@morbitton morbitton mentioned this pull request Jan 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmilbaum lmilbaum lmilbaum approved these changes

Assignees

@BarakMerdler BarakMerdler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding the layout file
2 participants
@BarakMerdler @lmilbaum