osd::devices allow working on dmcrypt block devices. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current workaround to apply osds to dmcrypt devices. Short overview: - disbaled creation of partition table and first partition. - removed the hardcoded first partition from creation of fs and more(templates etc.). - regex to remove mapper from incoming variables. Now need some clean up, some work on the handling of the device with the right partiton id. Maybe a check and a parameter option for creation of a partition.
Used the wrong variable inside the unless statment to check for existing xfs filesystem.
|
This pull-request is one year and a half old. I close it, but feel free to re-open it and work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing to create a partition on top of a
dmcryptblock devices. As well you can enablegptor not.ceph::osd::device { "/dev/mapper/osd-${id}":
partition_table => false,
partition_table_type => none,
}
This will apply a
osdto thedmcryptdevices without agptlayout. When you want to usea
gpttable on thedmcryptset this:ceph::osd::device { "/dev/mapper/osd-${id}":
partition_table => true,
partition_table_type => gpt,
dmcrypt_device
}
This will create a
gpton thedmcryptblock devices. By default agptpartition table will create.define ceph::osd::device (
$partition_table = true,
$partition_table_type = gpt,
$dmcrypt_device = false,
)
This is my solution for Unable to create filesystem on dmcrypt devices - puppet ceph issue #13. By default nothing changes for the call of the
osd::device.Only when required when having a
dmcryptdevice. More things will come later.Note: How the
dmcryptwill be unblock isn't take care of.so far
4k3nd0