feat: support passing a group description to GitLab #8937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanshortiss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding a group description is helpful in providing context. It also looks better in demos, since we won't have as many empty columns in RHDH.
Note: that this screenshot was taken after enabling the GitLab Org Discovery plugin. This is something that will require a change to our default RHDH config.
ISSUE TYPE
COMPONENT NAME
ocp4_workload_gitops_gitlab
ADDITIONAL INFORMATION
Requires a change in cm-gitlab-init.yaml to pass the description to the POST to the GitLab API. Will open a PR for that shortly.