-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMQ Broker Operator #324
AMQ Broker Operator #324
Conversation
There is currently a false negative in the lint-manifests job, due to the use of partial Kustomize Components. Components allow referencing resources that are not directly included within the manifest of the component. This "partial" view of a component allows us to make modification regardless of which other component introduced the resource. For example, the component at To help resolve this false negative, I've submitted a secondary pull request to skip components that fail a |
Will merge this as soon as the @codekow gives the thumbs up changing the linting process. |
LTGM. Thanks. |
Co-authored-by: Robert Grimm <[email protected]> Co-authored-by: Joe Strickland <[email protected]>
0f523e6
to
3aba0dc
Compare
I've rebased to pick up the changed script from #325 . I'll fix the lint-yaml errors and then remove draft status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition. Thanks!
This is a fantastic piece of work! As a follow up, I think it would be great if we could add some READMEs for the components that include some details of what each component does. I think that it really goes a long way to improve the usability of the components to have some details of what the component does. Take a look at what we did for the gitops operator as an example: |
Yes, I had planned to add documentation/READMEs throughout the amq-broker-operator tree. I haven't been able to dedicate the time to that yet and didn't want to continue holding the whole PR hostage to my time. Thank you for the link to reference, @strangiato ! As time allows, I'll aim to write additional documentation and follow conventions/styles from that gitops operator in future documentation PRs. |
@jstrickl-redhat and I have put together a base set of files for AMQ Broker Operator, including instance components to facilitate different sets of broker configuration.