Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMQ Broker Operator #324

Merged
merged 4 commits into from
Sep 4, 2024
Merged

AMQ Broker Operator #324

merged 4 commits into from
Sep 4, 2024

Conversation

rmgrimm
Copy link
Contributor

@rmgrimm rmgrimm commented Aug 20, 2024

@jstrickl-redhat and I have put together a base set of files for AMQ Broker Operator, including instance components to facilitate different sets of broker configuration.

@rmgrimm
Copy link
Contributor Author

rmgrimm commented Aug 20, 2024

There is currently a false negative in the lint-manifests job, due to the use of partial Kustomize Components. Components allow referencing resources that are not directly included within the manifest of the component. This "partial" view of a component allows us to make modification regardless of which other component introduced the resource.

For example, the component at amq-broker-operator/instance/components/certificates/public-ca-truststores/letsencrypt-prod/console-ssl-keystore expects a pre-existing secret named console-ssl-keystore and updates it to use a letsencrypt CA certificates for trust chains. There are multiple options for creating console-ssl-keystore, also including the implicit option to manually create the resource in an overlay.

To help resolve this false negative, I've submitted a secondary pull request to skip components that fail a kustomize build at #325

@pittar
Copy link
Collaborator

pittar commented Aug 22, 2024

Will merge this as soon as the @codekow gives the thumbs up changing the linting process.

@pittar
Copy link
Collaborator

pittar commented Aug 31, 2024

LTGM. Thanks.

@rmgrimm rmgrimm force-pushed the amq-broker-operator branch from 0f523e6 to 3aba0dc Compare September 4, 2024 16:49
@rmgrimm
Copy link
Contributor Author

rmgrimm commented Sep 4, 2024

I've rebased to pick up the changed script from #325 . I'll fix the lint-yaml errors and then remove draft status.

@rmgrimm rmgrimm marked this pull request as ready for review September 4, 2024 17:04
Copy link
Collaborator

@pittar pittar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition. Thanks!

@pittar pittar merged commit 45671bd into redhat-cop:main Sep 4, 2024
4 checks passed
@rmgrimm rmgrimm deleted the amq-broker-operator branch September 4, 2024 17:33
@strangiato
Copy link
Contributor

strangiato commented Sep 4, 2024

This is a fantastic piece of work!

As a follow up, I think it would be great if we could add some READMEs for the components that include some details of what each component does. I think that it really goes a long way to improve the usability of the components to have some details of what the component does.

Take a look at what we did for the gitops operator as an example:

https://github.com/redhat-cop/gitops-catalog/tree/main/openshift-gitops-operator/instance/components/annotation-resource-tracking

@rmgrimm
Copy link
Contributor Author

rmgrimm commented Sep 4, 2024

Yes, I had planned to add documentation/READMEs throughout the amq-broker-operator tree. I haven't been able to dedicate the time to that yet and didn't want to continue holding the whole PR hostage to my time.

Thank you for the link to reference, @strangiato ! As time allows, I'll aim to write additional documentation and follow conventions/styles from that gitops operator in future documentation PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants