fix broken deployment of jenkisn chart with default values #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethahealy
approved these changes
Dec 16, 2024
Signed-off-by: Zvi Grinberg <[email protected]>
zvigrinberg
force-pushed
the
fix-deploying-jenkins-with-defaults
branch
from
c25cd96 to
63ddbb0
Compare
|
@zvigrinberg you've removed the fix via the last force-push... |
|
@garethahealy |
|
yep, fixed last year: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR About?
This fixes the broken deployment of jenkins helm chart with default values - build of all agents fails in init container that performs git clone of agent resources and dockerfile .
How do we test this?
The same, just need to deploy the jenkins chart with default values, and see that all agents are now built successfully.
cc: @redhat-cop/day-in-the-life