Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAP-13847: Remove community.general.random_string dependencies #244

Merged
merged 4 commits into from
Jul 7, 2023
Merged

AAP-13847: Remove community.general.random_string dependencies #244

merged 4 commits into from
Jul 7, 2023

Conversation

thom-at-redhat
Copy link
Collaborator

@thom-at-redhat thom-at-redhat commented Jul 7, 2023 •
edited
Loading

Description

Remove community.general.random_string dependencies

FIXES: AAP-13847

Type of change

What is it?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Tests update
  • Refactor

Checklist

  • Added changelog fragment
  • Tests exist for affected features covering positive and negative scenarios

@mergify mergify bot added the refactor Code was improved label Jul 7, 2023
@thom-at-redhat thom-at-redhat marked this pull request as ready for review July 7, 2023 14:02
@mergify mergify bot merged commit 7a8aa32 into redhat-cop:main Jul 7, 2023
100 checks passed
@thom-at-redhat thom-at-redhat deleted the AAP-13838 branch July 7, 2023 14:24
@thom-at-redhat thom-at-redhat changed the title AAP-13838: Remove community.general.random_string dependencies AAP-13847: Remove community.general.random_string dependencies Jul 7, 2023
@mergify mergify bot added the waiting for review Pull request is ready for review label Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@de1987 de1987 de1987 approved these changes

@maxamillion maxamillion Awaiting requested review from maxamillion maxamillion is a code owner

@resoluteCoder resoluteCoder Awaiting requested review from resoluteCoder resoluteCoder is a code owner

@matoval matoval Awaiting requested review from matoval matoval is a code owner

Assignees
No one assigned
Labels
refactor Code was improved waiting for review Pull request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thom-at-redhat @de1987