Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAP-13082: Remove community.general references #252

Merged
merged 80 commits into from
Jul 26, 2023

Conversation

thom-at-redhat
Copy link
Collaborator

Description

Remove community.general references
FIXES: AAP-13082

Type of change

What is it?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Tests update
  • Refactor

Checklist

  • Added changelog fragment
  • Tests exist for affected features covering positive and negative scenarios

@mergify mergify bot added the refactor Code was improved label Jul 14, 2023
de1987
de1987 previously approved these changes Jul 14, 2023
@mergify mergify bot dismissed de1987’s stale review July 14, 2023 15:04

New commit(s) added, removing existing approval(s)

de1987
de1987 previously approved these changes Jul 14, 2023
@mergify mergify bot dismissed de1987’s stale review July 14, 2023 15:42

New commit(s) added, removing existing approval(s)

@thom-at-redhat
Copy link
Collaborator Author

thom-at-redhat commented Jul 17, 2023

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2023

rebase

✅ Branch has been successfully rebased

de1987
de1987 previously approved these changes Jul 17, 2023
@mergify mergify bot dismissed de1987’s stale review July 17, 2023 17:05

New commit(s) added, removing existing approval(s)

@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2023

This Pull Request is now in conflict. Could you fix it @thom-at-redhat? 🙏

@mergify mergify bot added conflict Merge is conflicting and removed conflict Merge is conflicting labels Jul 17, 2023
@omaciel
Copy link

omaciel commented Jul 21, 2023

I'd recommend squashing the commits when you're done, but that's just my opinion :)

@thom-at-redhat thom-at-redhat marked this pull request as ready for review July 25, 2023 19:55
@mergify mergify bot added the waiting for review Pull request is ready for review label Jul 25, 2023
@thom-at-redhat
Copy link
Collaborator Author

@Mergifyio squash

@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2023

squash

✅ Pull request squashed successfully

thom-at-redhat added a commit to thom-at-redhat/infra.osbuild that referenced this pull request Jul 25, 2023
AAP-13082: Remove community.general references

* Add changelog fragment

* Fix typo in shippable.sh

* Fix another typo in shippable.sh

* Revert disable_custom_repos so notify works

* Reorder parameters

* Comment out notify

* Add rhsm repos to test

* Merge branch 'main' into AAP-13082

* Changed to zoo repository as test fixture

* Changed from blockinfile to copy

* Removed validate

* Change to yum_repository

* Added name

* Added name

* Check for key in dictionary

* Check for key in dictionary

* Remove fedora from fqcn

* Fix rhc path and repository gpg test

* RHC typo fix attempt 1

* Change include_roles back to roles

* RHC typo fix attempt 2

* RHC typo fix attempt 3

* RHC typo fix attempt 4

* RHC typo fix attempt 5

* RHC typo fix attempt 6

* RHC typo fix attempt 7

* RHC typo fix attempt 8

* RHC typo fix attempt 9

* RHC typo fix attempt 10

* RHC typo fix attempt 11

* RHC typo fix attempt 12

* RHC typo fix attempt 13

* RHC typo fix attempt 14

* RHC typo fix attempt 15

* RHC typo fix attempt 16

* RHC typo fix attempt 17

* RHC typo fix attempt 18

* RHC typo fix attempt 19

* RHC typo fix attempt 19

* RHC typo fix attempt 19

* RHC typo fix attempt 20

* RHC typo fix attempt 21

* RHC typo fix attempt 22

* RHC typo fix attempt 23

* RHC typo fix attempt 24

* RHC typo fix attempt 25

* RHC typo fix attempt 26

* RHC typo fix attempt 27

* RHC typo fix attempt 28

* RHC typo fix attempt 29

* RHC typo fix attempt 30

* RHC typo fix attempt 31

* RHC typo fix attempt 32

* RHC typo fix attempt 33

* RHC typo fix attempt 34

* RHC typo fix attempt 36

* RHC typo fix attempt 37

* RHC typo fix attempt 38

* RHC typo fix attempt 39

* RHC typo fix attempt 40

* RHC typo fix attempt 41

* RHC typo fix attempt 43

* RHC typo fix attempt 44

* RHC typo fix attempt 45

* RHC typo fix attempt 46

* RHC typo fix attempt 47

* RHC typo fix attempt 48

* RHC typo fix attempt 49

* RHC typo fix attempt 50

* RHC typo fix attempt 51

* RHC typo fix attempt 52

* RHC typo fix attempt 53

* RHC typo fix attempt 54

* RHC typo fix attempt 55

* RHC typo fix attempt 56

* RHC typo fix attempt 57

* RHC typo fix attempt 58

* RHC typo fix attempt 59

* RHC typo fix attempt 60
@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2023

This Pull Request needs all conversation threads to be resolved. Could you fix it @thom-at-redhat? 🙏

@mergify mergify bot added question Further information is requested (all conversations resolved?) and removed waiting for review Pull request is ready for review labels Jul 25, 2023
@mergify mergify bot removed the question Further information is requested (all conversations resolved?) label Jul 26, 2023
@mergify mergify bot merged commit 834f8b5 into redhat-cop:main Jul 26, 2023
100 checks passed
@thom-at-redhat thom-at-redhat deleted the AAP-13082 branch July 26, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code was improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants