Add timeout param to start_compose #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
empovit
requested review from
maxamillion,
thom-at-redhat,
de1987,
resoluteCoder and
matoval
as code owners
mergify
bot
added
bug
empovit
force-pushed
the
fix-compose-timeouts
branch
from
5cb4305
to
2d6e274
Compare
empovit
force-pushed
the
fix-compose-timeouts
branch
from
39b7379
to
72aee2e
Compare
|
LGTM |
maxamillion
approved these changes
Jul 20, 2023
thom-at-redhat
added a commit
that referenced
this pull request
Jul 20, 2023
Fix lint errors introduced by #254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On first run after an osbuild-composer host has been set up , an OSBuild Composer API (Weldr) request may time out because of the systemd services still starting up. Setting a timeout value allows to tweak this behavior and avoid timeouts on slower build hosts.
FIXES: #182
Type of change
What is it?
Checklist