added populate aap vars #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resoluteCoder
requested review from
maxamillion,
thom-at-redhat,
de1987 and
matoval
as code owners
chadmf
requested changes
Jul 19, 2023
| username: user | ||
| ssh_key_data: "{{ lookup('file', '/home/user/.ssh/id_rsa') }}" | ||
| username: "{{ populate_aap_default_host_user }}" | ||
| ssh_key_data: "{{ lookup('file', populate_aap_ssh_key_path) if populate_aap_ssh_key_path is defined else '' }}" |
There was a problem hiding this comment.
This should be just the var {{ populate_aap_ssh_key_path }} and the role should contain all of the non variable information and then this would close the other issue #213
This is a best practice that the defaults should be vars not logic.
| username: user | ||
| ssh_key_data: "{{ lookup('file', '/home/user/.ssh/id_rsa') }}" | ||
| username: "{{ populate_aap_default_host_user }}" | ||
| ssh_key_data: "{{ lookup('file', populate_aap_ssh_key_path) if populate_aap_ssh_key_path is defined else '' }}" |
There was a problem hiding this comment.
Suggested change
| ssh_key_data: "{{ lookup('file', populate_aap_ssh_key_path) if populate_aap_ssh_key_path is defined else '' }}" | |
| ssh_key_data: "{{ populate_aap_ssh_key_path }}" |
There was a problem hiding this comment.
in addition to above you will need to change the role main task to have the lookup
|
This Pull Request needs all conversation threads to be resolved. Could you fix it @resoluteCoder? 🙏 |
mergify
bot
added
the
question
|
This Pull Request needs all changes requested to be resolved. Could you fix it @resoluteCoder? 🙏 |
matoval
approved these changes
Jul 30, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FIXES:
#213
Type of change
What is it?
Checklist