Include blueprint import file option #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisarizmendi
requested review from
maxamillion,
thom-at-redhat,
de1987,
resoluteCoder and
matoval
as code owners
|
LGTM - CI failures are unrelated, it looks like the dev branch for ansible-core moved the goal posts and make existing code non-compliant with lint checks. I 'll deal with that later. |
maxamillion
approved these changes
Mar 6, 2024
|
This Pull Request needs all checks to run successfully. Could you fix it @luisarizmendi? 🙏 |
|
This Pull Request needs all checks to run successfully. Could you fix it @luisarizmendi? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first approach to cover [1]. I didn't modify any module, I just added a new
builder_blueprint_import_filevariable. If the variable is defined, then it copies the file into the image builder, and then pushes that blueprint instead of creating the blueprint from the vars.[1] #225
NOTE: This pull request has been reopened because the previous one became "stale." I believe the changes are still relevant and warrant consideration. Thank you for your attention to this matter.
Type of change
What is it?
Checklist
Checklist