Allow setting worker replica count to 0 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some OpenShift cluster topologies (single node openshift, schedulable master nodes) require creating a cluster with zero worker nodes. We want to be able to deploy clusters with this configuration to more optimally use our cloud resource quotas. This change is necessary to allow OSIA to provision a cluster with zero workers. Prior to this change, if you set the count to zero with the CLI `--worker-replicas` flag, Jinja would interpret zero as False and therefore use the default value of 3. This moves the logic for setting the default value to the base cloud class. I moved the master node replica count logic to the same place for consistency.
|
@mijaros let me know what you think of this change when you have a chance. |
|
Looking into it, and it makes sense, for me the base issue is to use the default once it is not set. This does exactly that. Thank you for the contribution. |
mijaros
approved these changes
Dec 12, 2023
|
Thanks @mijaros! Do you know when you plan to cut a new release that will include this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some OpenShift cluster topologies (single node openshift, schedulable master nodes) require creating a cluster with zero worker nodes. We want to be able to deploy clusters with this configuration to more optimally use our cloud resource quotas. This change is necessary to allow OSIA to provision a cluster with zero workers. Prior to this change, if you set the count to zero with the CLI
--worker-replicasflag, Jinja would interpret zero as False and therefore use the default value of 3. This moves the logic for setting the default value to the base cloud class. I moved the master node replica count logic to the same place for consistency.