Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for platform.machine() == aarch64 on Linux #85

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

grdryn
Copy link
Contributor

@grdryn grdryn commented Dec 19, 2024

$ python -c 'import platform; print(platform.machine())'
aarch64

I'm not sure if in some cases it returns arm64, so I just left that
possibility there.

Copy link
Collaborator

@Frawless Frawless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should return same values as uname -m, I tried it on AWS with arm instance and it returns aarch64. Guess we can keep the old way and remove it in the future.

@Frawless Frawless requested a review from mdujava December 19, 2024 07:45
$ python -c 'import platform; print(platform.machine())'
aarch64

I'm not sure if in some cases it returns arm64, so I just left that
possibility there.
@grdryn
Copy link
Contributor Author

grdryn commented Dec 19, 2024

Updated to (hopefully) fix the linter error on 3.11 that was complaining about the line being too long.

@mdujava mdujava merged commit 5ad7b28 into redhat-cop:devel Dec 20, 2024
4 checks passed
@grdryn grdryn deleted the linux-aarch64 branch December 20, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants