Ignore kubeconfig changes where the config file is empty or deleted #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not convinced this is doing much to address redhat-developer/intellij-kubernetes#640. In practice, the first few times I attempt to switch namespaces, the tree collapses, regardless of if I use this PR or the existing code. After that, I can occasionally switch namespaces without the tree collapsing. See redhat-developer#190. Signed-off-by: David Thompson <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
@datho7561 sorry, missed this one. Will look into it asap. |
|
@datho7561 thanks a lot for filing this. I believe that the fixes that you provided here also are in #192. Unfortunately I missed yours when filing my fix. It would have spared me from doing the work you already did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not convinced this is doing much to address redhat-developer/intellij-kubernetes#640. In practice, the first few times I attempt to switch namespaces, the tree collapses, regardless of if I use this PR or the existing code. After that, I can occasionally switch namespaces without the tree collapsing.
See #190.
Signed-off-by: David Thompson [email protected]