Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable PushNotification #763

Closed
JustinLex opened this issue Jun 15, 2024 · 3 comments · Fixed by #790
Closed

Option to disable PushNotification #763

JustinLex opened this issue Jun 15, 2024 · 3 comments · Fixed by #790
Assignees

Comments

@JustinLex
Copy link

The PushNotification is not useful for GitOps workflows, and it is distracting to the user. There should be an option to disable the PushNotification. (i.e. the "Push to create Deployment 'foobar'?" notification)

@adietish
Copy link
Collaborator

adietish commented Jun 24, 2024

Hi @JustinLex

Thanks for reporting this. I'll add an option in the preferences to disable those.
In your workflow, iIs there still some value in less intrusive indications that the editor was changed (ex. * in the editor title, push icon gets highlighted) or can we drop any kind of modification-notification alltogether?

ps. Off the top of your head, is there any Is there anything that would help GitOps workflows and that is missing currently? I'd love to get your thoughts it you have any.

@adietish adietish self-assigned this Jul 16, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Oct 2, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Oct 2, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Oct 2, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Oct 2, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Oct 2, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Oct 2, 2024
@adietish
Copy link
Collaborator

adietish commented Oct 3, 2024

Hi @JustinLex

Am I right in thinking that you dont want any automatic sync with the cluster to happen? You only want to push & pull when you hit the toolbar buttons. Correct?

adietish added a commit to adietish/intellij-kubernetes that referenced this issue Oct 3, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Oct 3, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Oct 3, 2024
@adietish
Copy link
Collaborator

adietish commented Oct 3, 2024

@JustinLex:
I now offer a setting where you can prevent the editor from syncronizing with the cluster:

image

Sync is enabled by default. You can disable it and it'll survive a restart of the IDE.

If sync is disabled you're not bothered to push your editor when it's modified (when compared to the cluster resource). Notifications of a resource that was deleted on the cluster are not displayed either.

You're still told of the result of pushing via the toolbar ("Resource was updated/created") and errors are notified, too, of course.

Hope that this is matching your expectations 😃

adietish added a commit to adietish/intellij-kubernetes that referenced this issue Oct 3, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Oct 3, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Oct 4, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Oct 4, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Oct 6, 2024
adietish added a commit that referenced this issue Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants