-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to disable editor notifications (#763) #790
Conversation
0c4f8e2
to
c6c12ad
Compare
52f25ff
to
7fff71f
Compare
How to test this: My first question is: is the label for the checkbox explaining what happens if you check/uncheck it? The most basic is test could look like this: Steps:
apiVersion: v1
kind: ConfigMap
metadata:
name: base64encoded
data:
foo: text value that noone ca
binaryData:
bar: jmjKxUGNs/WqDQ==
Result: Further tests could be done with a multi-resource file and minikube. Multi-resource editors are not notified of the success of the push. ---
apiVersion: apps/v1
kind: Deployment
metadata:
annotations:
app.quarkus.io/commit-id: 874731470682e3f213506357d2f9887bab63be83
app.quarkus.io/build-timestamp: 2023-04-25 - 09:17:12 +0000
labels:
app.kubernetes.io/name: code-with-quarkus
app.kubernetes.io/version: 1.0.0-SNAPSHOT
name: code-with-quarkus
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/name: code-with-quarkus
app.kubernetes.io/version: 1.0.0-SNAPSHOT
template:
metadata:
annotations:
app.quarkus.io/commit-id: 874731470682e3f213506357d2f9887bab63be83
app.quarkus.io/build-timestamp: 2023-04-25 - 09:17:12 +0000
labels:
app.kubernetes.io/name: code-with-quarkus
app.kubernetes.io/version: 1.0.0-SNAPSHOT
spec:
containers:
- env:
- name: KUBERNETES_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
image: minikube/andredietisheim/code-with-quarkus:1.0.0-SNAPSHOT
imagePullPolicy: IfNotPresent
name: code-with-quarkus
ports:
- containerPort: 8080
name: http
protocol: TCP
---
apiVersion: v1
kind: Service
metadata:
annotations:
app.quarkus.io/commit-id: 874731470682e3f213506357d2f9887bab63be83
app.quarkus.io/build-timestamp: 2023-04-25 - 09:17:12 +0000
labels:
app.kubernetes.io/name: code-with-quarkus
app.kubernetes.io/version: 1.0.0-SNAPSHOT
name: code-with-quarkus
spec:
ports:
- name: http
nodePort: 31995
port: 80
protocol: TCP
targetPort: 8080
selector:
app.kubernetes.io/name: code-with-quarkus
app.kubernetes.io/version: 1.0.0-SNAPSHOT
type: NodePort |
Signed-off-by: Andre Dietisheim <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. good work !
fixes #763