Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bumped schema to v1.25.3 (#501) #507

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bumped schema to v1.25.3 (#501) #507

wants to merge 1 commit into from

Conversation

adietish
Copy link
Collaborator

fixes #501

@adietish adietish self-assigned this Oct 24, 2022
@adietish adietish added this to the 0.7.0 milestone Oct 24, 2022
@adietish adietish removed this from the 0.7.0 milestone Oct 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

lstocchi
lstocchi approved these changes Oct 25, 2022
View reviewed changes
Copy link

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adietish
Copy link
Collaborator Author

adietish commented Oct 25, 2022 •
edited
Loading

@lstocchi, @jeffmaury: it's striking how much is removed with this bump:
image

The explanation is that many deprecated items were removed. The details can be read in the deprecation guide at kubernetes.io: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25

The v1.25 release will stop serving the following deprecated API versions:

  • CronJob
  • EndpointSlice
  • Event
  • HorizontalPodAutoscaler
  • PodDisruptionBudget
  • PodSecurityPolicy
  • PodSecurityPolicy
  • RuntimeClass

One could wonder if we should support multiple schema.
Thoughts?

@jeffmaury
Copy link
Member

@lstocchi, @jeffmaury: it's striking how much is removed with this bump: image

The explanation is that many deprecated items were removed. The details can be read in the deprecation guide at kubernetes.io: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25

The v1.25 release will stop serving the following deprecated API versions:

  • CronJob
  • EndpointSlice
  • Event
  • HorizontalPodAutoscaler
  • PodDisruptionBudget
  • PodSecurityPolicy
  • PodSecurityPolicy
  • RuntimeClass

One could wonder if we should support multiple schema. Thoughts?

We should support several Kubernetes versions and not only the last one.
In IntelliJ Tekton they removed some CRDs but I kept the schemas

@mohitsuman
Copy link
Collaborator

@adietish What's the status of this PR ? Should we merge this to main ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lstocchi lstocchi lstocchi approved these changes

@jeffmaury jeffmaury Awaiting requested review from jeffmaury

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bump schema to 1.25.3
4 participants
@adietish @jeffmaury @mohitsuman @lstocchi