Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added IC-2023.2 in matrix and pluginVerifier (#598) #599

Merged
merged 4 commits into from
Jul 31, 2023
Merged

added IC-2023.2 in matrix and pluginVerifier (#598) #599

merged 4 commits into from
Jul 31, 2023

Conversation

adietish
Copy link
Collaborator

fixes #598

@adietish adietish self-assigned this May 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@adietish adietish marked this pull request as draft May 15, 2023 15:46
@adietish
Copy link
Collaborator Author

my bad, IC-2023.2 is EAP so far, stable is at IC-2023.1.1. We need to wait.

@adietish adietish force-pushed the issue-598 branch 3 times, most recently from 7345a21 to 0c1feec Compare July 31, 2023 10:23
@adietish adietish marked this pull request as ready for review July 31, 2023 10:23
@adietish adietish marked this pull request as draft July 31, 2023 13:36
@adietish adietish force-pushed the issue-598 branch 2 times, most recently from ba8afe6 to 59df6b4 Compare July 31, 2023 16:39
@adietish adietish marked this pull request as ready for review July 31, 2023 17:28
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adietish
Copy link
Collaborator Author

@JessicaJHee: Could you please test this opening a terminal to a pod and see if the term works fine for you? Thanks!

JessicaJHee
JessicaJHee approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@JessicaJHee JessicaJHee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that the terminal works fine for me!

@adietish
Copy link
Collaborator Author

@JessicaJHee awesomeness, thanks!

@adietish adietish merged commit a98cac4 into redhat-developer:main Jul 31, 2023
15 checks passed
@adietish adietish deleted the issue-598 branch July 31, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessicaJHee JessicaJHee JessicaJHee approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add validation 2023.2 and verify compatibility
2 participants
@adietish @JessicaJHee