correctly synchronize accessing client when config changes (#640) #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…veloper#640) Signed-off-by: Andre Dietisheim <[email protected]>
|
This fixes the issue where the context is replaced with in the tree, but the tree view still refreshes |
adietish
force-pushed
the
issue-640
branch
2 times, most recently
from
ca92fb0
to
70d1c9b
Compare
|
I tried again, but the latest change doesn't prevent the tree view from refreshing |
Signed-off-by: Andre Dietisheim <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
@datho7561 thanks for testing. So I'd suggest to merge the PR since it fixes the critical issue where the context would become . I'd then keep the issue open (or create a new one) for the remaining issue where the refresh is still happening. |
datho7561
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possibly fixes #640 (not sure because I cannot replicate the issue)