Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use common that only notifies non-empty, complete kube config (#640) #646

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

adietish
Copy link
Collaborator

@adietish adietish commented Jul 26, 2023

should use redhat-developer/intellij-common#190 where non-existing, empty or invalid kube config files would not send change notifications any more.

@adietish adietish self-assigned this Jul 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@olkornii olkornii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adietish adietish merged commit 4c7cce9 into redhat-developer:main Jul 26, 2023
14 checks passed
@adietish adietish deleted the issue-640 branch July 26, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants